Skip to content

Support showing a block bound by qevent

Petr Machata netdev 3 versions Applied

Status from this message: applied to iproute2-next. Thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 2 repliesApplied
  2. v22 patches 4 repliesSuperseded
  3. v12 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- Patch #1:
- Do not pass &ctx->found directly to has_block. Do it through a helper variable, so that the callee does not overwrite the result already stored in ctx->found.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/2tc: Look for blocks in qeventstc/tc_qdisc.c tc/tc_qevent.c tc/tc_qevent.h +1 more+37 -01 reply
2/2tc: q_red: Implement has_block for REDtc/q_red.c+17 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJiri Pirko
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH iproute2-next v3 0/2] Support showing a block bound by qevent

When a list of filters at a given block is requested, tc first validates that the block exists before doing the filter query. Currently the validation routine checks ingress and egress blocks. But now that blocks can be bound to qevents as well, qevent blocks should be looked for as well:

    # ip link add up type dummy
    # tc qdisc add dev dummy1 root handle 1: \
         red min 30000 max 60000 avpkt 1000 qevent early_drop block 100
    # tc filter add block 100 pref 1234 handle 102 matchall action drop
    # tc filter show block 100
    Cannot find block "100"

This patchset fixes this issue:

    # tc filter show block 100
    filter protocol all pref 1234 matchall chain 0 
    filter protocol all pref 1234 matchall chain 0 handle 0x66 
      not_in_hw
            action order 1: gact action drop
             random type none pass val 0
             index 2 ref 1 bind 1

In patch #1, the helpers and necessary infrastructure is introduced, including a new qdisc_util callback that implements sniffing out bound blocks in a given qdisc.

In patch #2, RED implements the new callback.

v3:
- Patch #1:
- Do not pass &ctx->found directly to has_block. Do it through a helper variable, so that the callee does not overwrite the result already stored in ctx->found.

v2:
- Patch #1:
- In tc_qdisc_block_exists_cb(), do not initialize 'q'.
- Propagate upwards errors from q->has_block.

Petr Machata (2):
tc: Look for blocks in qevents
tc: q_red: Implement has_block for RED

 tc/q_red.c     | 17 +++++++++++++++++
 tc/tc_qdisc.c  | 18 ++++++++++++++++++
 tc/tc_qevent.c | 15 +++++++++++++++
 tc/tc_qevent.h |  2 ++
 tc/tc_util.h   |  2 ++
 5 files changed, 54 insertions(+)
Signature · 1 line
2.20.1