Skip to content

fcntl, sockopt, and ioctl options

Shu-Chun Weng qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 13 repliesIn review
  2. v16 patches 4 repliesSuperseded

Changes in v2 from the cover letter

Address comments on the first 5 (was 3) patches. Fix style problems.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8linux-user: Support F_ADD_SEALS and F_GET_SEALS fcntlslinux-user/strace.c linux-user/syscall.c linux-user/syscall_defs.h+64 -151 reply
2/8linux-user: add missing UDP get/setsockopt optionlinux-user/strace.c linux-user/syscall.c+11 -22 replies
3/8linux-user: add missing IPv6 get/setsockopt optionlinux-user/syscall.c+3 -00 replies
4/8linux-user: Add IPv6 options to do_print_sockopt()linux-user/strace.c+108 -03 replies
5/8linux-user: Update SO_TIMESTAMP to SO_TIMESTAMP_OLD/NEWlinux-user/alpha/sockbits.h linux-user/generic/sockbits.h linux-user/hppa/sockbits.h +5 more+408 -272 replies
6/8linux-user: setsockopt() SO_TIMESTAMPNS and SO_TIMESTAMPINGlinux-user/alpha/sockbits.h linux-user/generic/sockbits.h linux-user/hppa/sockbits.h +5 more+540 -1171 reply
7/8thunk: supports flexible arraysinclude/exec/user/thunk.h thunk.c+174 -22 replies
8/8linux-user: Add support for SIOCETHTOOL ioctllinux-user/Makefile.objs linux-user/ethtool.c linux-user/ethtool.h +7 more+1712 -121 reply

Reviews trailers per patch

4 of 8 patches have a Reviewed-by or Acked-by.

PatchLaurent Vivier
1/8R-b
2/8R-b R-b
3/8R-b
4/8R-b
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/8] fcntl, sockopt, and ioctl options

Hi Laurent,

This is a series of 8 patches in 4 groups, putting into a single thread for easier tracking.

[PATCH v2 1/8] linux-user: Support F_ADD_SEALS and F_GET_SEALS fcntls
An incidental follow up on
https://lists.nongnu.org/archive/html/qemu-devel/2019-09/msg01925.html

[PATCH v2 2/8] linux-user: add missing UDP get/setsockopt option [PATCH v2 3/8] linux-user: add missing IPv6 get/setsockopt option [PATCH v2 4/8] linux-user: Add IPv6 options to do_print_sockopt()
Updated https://lists.nongnu.org/archive/html/qemu-devel/2019-09/msg01317.html
to consistently add them in get/setsockopt

[PATCH v2 5/8] linux-user: Update SO_TIMESTAMP to SO_TIMESTAMP_OLD/NEW [PATCH v2 6/8] linux-user: setsockopt() SO_TIMESTAMPNS and SO_TIMESTAMPING
Updated https://lists.nongnu.org/archive/html/qemu-devel/2019-09/msg01319.html
to only use TARGET_SO_*_OLD/NEW

[PATCH v2 7/8] thunk: supports flexible arrays
[PATCH v2 8/8] linux-user: Add support for SIOCETHTOOL ioctl
Updated https://lists.nongnu.org/archive/html/qemu-devel/2019-08/msg05090.html

v1 -> v2:
Address comments on the first 5 (was 3) patches. Fix style problems.

Shu-Chun Weng (8):
linux-user: Support F_ADD_SEALS and F_GET_SEALS fcntls
linux-user: add missing UDP get/setsockopt option
linux-user: add missing IPv6 get/setsockopt option
linux-user: Add IPv6 options to do_print_sockopt()
linux-user: Update SO_TIMESTAMP to SO_TIMESTAMP_OLD/NEW
linux-user: setsockopt() SO_TIMESTAMPNS and SO_TIMESTAMPING
thunk: supports flexible arrays
linux-user: Add support for SIOCETHTOOL ioctl

 include/exec/user/thunk.h              |  24 +
 linux-user/Makefile.objs               |   3 +-
 linux-user/alpha/sockbits.h            |  21 +-
 linux-user/ethtool.c                   | 840 +++++++++++++++++++++++++
 linux-user/ethtool.h                   |  20 +
 linux-user/ethtool_entries.h           | 107 ++++
 linux-user/generic/sockbits.h          |  17 +-
 linux-user/hppa/sockbits.h             |  20 +-
 linux-user/ioctls.h                    |   2 +
 linux-user/mips/sockbits.h             |  16 +-
 linux-user/qemu.h                      |   1 +
 linux-user/sparc/sockbits.h            |  21 +-
 linux-user/strace.c                    | 188 +++++-
 linux-user/syscall.c                   | 286 ++++++++-
 linux-user/syscall_defs.h              |  26 +-
 linux-user/syscall_types.h             | 280 +++++++++
 tests/tcg/multiarch/ethtool.c          | 423 +++++++++++++
 tests/tcg/multiarch/socket_timestamp.c | 540 ++++++++++++++++
 thunk.c                                | 152 ++++-
 19 files changed, 2916 insertions(+), 71 deletions(-)
 create mode 100644 linux-user/ethtool.c
 create mode 100644 linux-user/ethtool.h
 create mode 100644 linux-user/ethtool_entries.h
 create mode 100644 tests/tcg/multiarch/ethtool.c
 create mode 100644 tests/tcg/multiarch/socket_timestamp.c
Signature · 1 line
2.28.0.220.ged08abb693-goog