Skip to content

Fixes and improvements for cryptodisks+luks2 and a few other things.

[email protected] grub-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17configure: Add Ubuntu dejavu font path.configure.ac+1 -12 replies
2/17cryptodisk: Fix cipher IV mode 'plain64' always being set as 'plain'.grub-core/disk/cryptodisk.c+2 -20 replies
3/17cryptodisk: Incorrect calculation of start sector for grub_disk_read in grub_cryptodisk_read.grub-core/disk/cryptodisk.c+2 -20 replies
4/17cryptodisk: Add more verbosity when reading/writing cryptodisks.grub-core/disk/cryptodisk.c+8 -40 replies
5/17luks: Add support for LUKS2 in (proc)/luks_scriptgrub-core/disk/cryptodisk.c+10 -82 replies
6/17luks2: grub_cryptodisk_t->total_length is the max number of device native sectors.grub-core/disk/luks2.c+4 -32 replies
7/17cryptodisk, luks: Allow special processing for comparing UUIDs.grub-core/disk/cryptodisk.c grub-core/disk/luks.c grub-core/disk/luks2.c +1 more+28 -192 replies
8/17cryptodisk: Unregister cryptomount command when removing module.grub-core/disk/cryptodisk.c+1 -00 replies
9/17fs: When checking if a block list goes past the end of the disk, make sure the total size of the disk is in grub native sector sizes, otherwise there will be blocks at the end of the disk unaccessible by block lists.grub-core/kern/fs.c+3 -11 reply
10/17cryptodisk: Properly handle non-512 byte sized sectors.grub-core/disk/cryptodisk.c grub-core/disk/luks.c grub-core/disk/luks2.c +1 more+35 -240 replies
11/17cryptodisk: Rename total_length field in grub_cryptodisk_t to total_sectors.grub-core/disk/cryptodisk.c grub-core/disk/geli.c grub-core/disk/luks.c +2 more+6 -62 replies
12/17fs: Allow number of blocks in block list to be optional, where length will be defaulted to the length of the device.grub-core/kern/fs.c+5 -10 replies
13/17loopback: Add procfs entry 'loopbacks' to output configured loopback devices.grub-core/disk/loopback.c+56 -00 replies
14/17cryptodisk: Add header line to procfs entry and crypto and source device names.grub-core/disk/cryptodisk.c+21 -50 replies
15/17cryptodisk: Add a couple comments noting the usage of a couple fields in grub_cryptodisk_t as is done for grub_disk_t.include/grub/cryptodisk.h+6 -00 replies
16/17luks2: Ensure that bit fields of grub_luks2_digest_t in luks2_parse_digest are initialized before returning.grub-core/disk/luks2.c+2 -00 replies
17/17luks2: Fix use of incorrect index and some error messages.grub-core/disk/luks2.c+7 -72 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/17] Fixes and improvements for cryptodisks+luks2 and a few other things.

From: Glenn Washburn <[email protected]>

Hi All,

Here's a list of patches that mostly have to do with cryptodisk and luks2 fixes or improvements. The odd balls out are the patches adding the ubuntu font path, a fix an an improvement to blocklists, and adding a procfs entry for loopbacks. I'm hoping that at least the luks2 and cryptodisk sector size fixes can be included for the 2.06 release (non-512 byte sectors are definitely broken for LUKS2). Let me know if there's anything else I can do to help get these merged or messed something up in sending the emails (first time sending patches through git).

Thanks for all the hard work,
Glenn

Glenn Washburn (17):
configure: Add Ubuntu dejavu font path.
cryptodisk: Fix cipher IV mode 'plain64' always being set as 'plain'.
cryptodisk: Incorrect calculation of start sector for grub_disk_read
in grub_cryptodisk_read.
cryptodisk: Add more verbosity when reading/writing cryptodisks.
luks: Add support for LUKS2 in (proc)/luks_script
luks2: grub_cryptodisk_t->total_length is the max number of device
native sectors.
cryptodisk,luks: Allow special processing for comparing UUIDs.
cryptodisk: Unregister cryptomount command when removing module.
fs: When checking if a block list goes past the end of the disk, make
sure the total size of the disk is in grub native sector sizes, otherwise there will be blocks at the end of the disk unaccessible by block lists.
cryptodisk: Properly handle non-512 byte sized sectors.
cryptodisk: Rename total_length field in grub_cryptodisk_t to
total_sectors.
fs: Allow number of blocks in block list to be optional, where length
will be defaulted to the length of the device.
loopback: Add procfs entry 'loopbacks' to output configured loopback
devices.
cryptodisk: Add header line to procfs entry and crypto and source
device names.
cryptodisk: Add a couple comments noting the usage of a couple fields
in grub_cryptodisk_t as is done for grub_disk_t.
luks2: Ensure that bit fields of grub_luks2_digest_t in
luks2_parse_digest are initialized before returning.
luks2: Fix use of incorrect index and some error messages.

 configure.ac                |   2 +-
 grub-core/disk/cryptodisk.c | 111 +++++++++++++++++++++++-------------
 grub-core/disk/geli.c       |   2 +-
 grub-core/disk/loopback.c   |  56 ++++++++++++++++++
 grub-core/disk/luks.c       |  27 +++------
 grub-core/disk/luks2.c      |  31 ++++++----
 grub-core/kern/fs.c         |  10 +++-
 include/grub/cryptodisk.h   |  10 +++-
 include/grub/misc.h         |  21 +++++++
 9 files changed, 192 insertions(+), 78 deletions(-)
Signature · 1 line
2.25.1