Skip to content

usb: dwc3: gadget: Fix halt/clear_stall handling

Thinh Nguyen linux-usb stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v13 patches 16 repliesSuperseded

Changes in v2 from the cover letter

- Rebased on 5.9-rc3
- Remove a cleanup patch so this series can be merged to 5.9-rcX
- Account for wedged endpoint
- Account for CLEAR_FEATURE on stopped endpoints with pending requests (END_TRANSFER command won't be issued for stopped endpoints, so just kick pending request right after CLEAR_STALL)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2usb: dwc3: gadget: Resume pending requests after CLEAR_STALLdrivers/usb/dwc3/gadget.c+14 -81 reply
2/2usb: dwc3: gadget: END_TRANSFER before CLEAR_STALL commanddrivers/usb/dwc3/core.h drivers/usb/dwc3/ep0.c drivers/usb/dwc3/gadget.c +1 more+50 -81 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] usb: dwc3: gadget: Fix halt/clear_stall handling

This series fixes a couple of driver issues handling ClearFeature(halt) request:

1) A function driver often uses set_halt() to reject a class driver protocol command. After set_halt(), the endpoint will be stalled. It can queue new requests while the endpoint is stalled. However, dwc3 currently drops those requests after CLEAR_STALL. The driver should only drop started requests. Keep the pending requests in the pending list to resume and process them after the host issues ClearFeature(Halt) to the endpoint.

2) DWC3 should issue CLEAR_STALL command _after_ END_TRANSFER command completes.

Changes in v2:
- Rebased on 5.9-rc3
- Remove a cleanup patch so this series can be merged to 5.9-rcX
- Account for wedged endpoint
- Account for CLEAR_FEATURE on stopped endpoints with pending requests (END_TRANSFER command won't be issued for stopped endpoints, so just kick pending request right after CLEAR_STALL)

Thinh Nguyen (2):
usb: dwc3: gadget: Resume pending requests after CLEAR_STALL
usb: dwc3: gadget: END_TRANSFER before CLEAR_STALL command

 drivers/usb/dwc3/core.h   |  1 +
 drivers/usb/dwc3/ep0.c    | 16 +++++++++++
 drivers/usb/dwc3/gadget.c | 56 ++++++++++++++++++++++++++++++---------
 drivers/usb/dwc3/gadget.h |  1 +
 4 files changed, 61 insertions(+), 13 deletions(-)

base-commit: f75aef392f869018f78cfedf3c320a6b3fcfda6b

Signature · 1 line
2.28.0

Read the cover letter in its thread