Skip to content

Fixes and improvements for cryptodisks+luks2 and a few other things.

Glenn Washburn grub-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19configure: Add Ubuntu dejavu font path.configure.ac+1 -10 replies
2/19cryptodisk: Fix cipher IV mode 'plain64' always being set as 'plain'.grub-core/disk/cryptodisk.c+2 -20 replies
3/19cryptodisk: Incorrect calculation of start sector for grub_disk_read in grub_cryptodisk_read.grub-core/disk/cryptodisk.c+2 -27 replies
4/19cryptodisk: Add more verbosity when reading/writing cryptodisks.grub-core/disk/cryptodisk.c+8 -40 replies
5/19luks2: Add support for LUKS2 in (proc)/luks_scriptgrub-core/disk/cryptodisk.c+12 -80 replies
6/19luks2: Rename source disk variabled named 'disk' to 'source' as in luks.c.grub-core/disk/luks2.c+11 -110 replies
7/19luks2: grub_cryptodisk_t->total_length is the max number of device native sectors.grub-core/disk/luks2.c+8 -31 reply
8/19cryptodisk, luks: Allow special processing for comparing UUIDs.grub-core/disk/cryptodisk.c grub-core/disk/luks.c grub-core/disk/luks2.c +1 more+28 -191 reply
9/19cryptodisk: Unregister cryptomount command when removing module.grub-core/disk/cryptodisk.c+1 -00 replies
10/19fs: Fix block lists not being able to address to end of disk sometimes.grub-core/kern/fs.c+3 -10 replies
11/19cryptodisk: Properly handle non-512 byte sized sectors.grub-core/disk/cryptodisk.c grub-core/disk/luks.c grub-core/disk/luks2.c +1 more+35 -240 replies
12/19cryptodisk: Rename total_length field in grub_cryptodisk_t to total_sectors.grub-core/disk/cryptodisk.c grub-core/disk/geli.c grub-core/disk/luks.c +2 more+6 -60 replies
13/19fs: Allow number of blocks in block list to be optional, where length will be defaulted to the length of the device.grub-core/kern/fs.c+5 -10 replies
14/19loopback: Add procfs entry 'loopbacks' to output configured loopback devices.grub-core/disk/loopback.c+56 -00 replies
15/19cryptodisk, luks2: Add header line to procfs entry and crypto and source device names.grub-core/disk/cryptodisk.c+22 -62 replies
16/19cryptodisk: Add a couple comments noting the usage of a couple fields in grub_cryptodisk_t as is done for grub_disk_t.include/grub/cryptodisk.h+6 -00 replies
17/19luks2: Ensure that bit fields of grub_luks2_digest_t in luks2_parse_digest are initialized before returning.grub-core/disk/luks2.c+2 -00 replies
18/19luks2: Fix use of incorrect index and some error messages.grub-core/disk/luks2.c+18 -170 replies
19/19cryptodisk: Rename offset in grub_cryptodisk_t to offset_sectors to improve readability.grub-core/disk/cryptodisk.c grub-core/disk/geli.c grub-core/disk/luks.c +2 more+12 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [CRYPTO-LUKS v1 00/19] Fixes and improvements for cryptodisks+luks2 and a few other things.

I've changed the name of the patch series to make it more self-explanatory, but still incremented the version number. All of Patrick's suggestions have been added in. I've added 2 new patches, one suggested by Patrick for rename cryptodisk's offset member to offset_sectors. And another to rename 'disk' to 'source' where appropriate in luks2.c.

Glenn Washburn (19):
configure: Add Ubuntu dejavu font path.
cryptodisk: Fix cipher IV mode 'plain64' always being set as 'plain'.
cryptodisk: Incorrect calculation of start sector for grub_disk_read
in grub_cryptodisk_read.
cryptodisk: Add more verbosity when reading/writing cryptodisks.
luks2: Add support for LUKS2 in (proc)/luks_script
luks2: Rename source disk variabled named 'disk' to 'source' as in

    luks.c.

luks2: grub_cryptodisk_t->total_length is the max number of device
native sectors.
cryptodisk,luks: Allow special processing for comparing UUIDs.
cryptodisk: Unregister cryptomount command when removing module.
fs: Fix block lists not being able to address to end of disk
sometimes.
cryptodisk: Properly handle non-512 byte sized sectors.
cryptodisk: Rename total_length field in grub_cryptodisk_t to
total_sectors.
fs: Allow number of blocks in block list to be optional, where length
will be defaulted to the length of the device.
loopback: Add procfs entry 'loopbacks' to output configured loopback
devices.
cryptodisk,luks2: Add header line to procfs entry and crypto and
source device names.
cryptodisk: Add a couple comments noting the usage of a couple fields
in grub_cryptodisk_t as is done for grub_disk_t.
luks2: Ensure that bit fields of grub_luks2_digest_t in
luks2_parse_digest are initialized before returning.
luks2: Fix use of incorrect index and some error messages.
cryptodisk: Rename offset in grub_cryptodisk_t to offset_sectors to
improve readability.

 configure.ac                |   2 +-
 grub-core/disk/cryptodisk.c | 115 +++++++++++++++++++++++-------------
 grub-core/disk/geli.c       |   4 +-
 grub-core/disk/loopback.c   |  56 ++++++++++++++++++
 grub-core/disk/luks.c       |  29 +++------
 grub-core/disk/luks2.c      |  78 +++++++++++++-----------
 grub-core/kern/fs.c         |  10 +++-
 include/grub/cryptodisk.h   |  12 +++-
 include/grub/misc.h         |  21 +++++++
 9 files changed, 224 insertions(+), 103 deletions(-)
Signature · 1 line
2.25.1