Skip to content

RFC mptcp: multiple xmit substreams support

Paolo Abeni mptcp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest12 patches 19 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12mptcp: msk is writable according to msk write spacenet/mptcp/protocol.c net/mptcp/subflow.c+25 -202 replies
2/12mptcp: set data_ready status bit in subflow_check_data_avail()net/mptcp/subflow.c+8 -110 replies
3/12mptcp: trigger msk processing even for OoO datanet/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/subflow.c+75 -423 replies
4/12mptcp: basic sndbuf autotuningnet/mptcp/protocol.c+13 -41 reply
5/12mptcp: introduce and use mptcp_try_coalesce()net/mptcp/protocol.c+19 -121 reply
6/12mptcp: move ooo skbs into msk out of order queue.net/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/subflow.c+198 -470 replies
7/12mptcp: cleanup mptcp_subflow_discard_data()net/mptcp/protocol.h net/mptcp/subflow.c+12 -422 replies
8/12mptcp: add OoO related mibsnet/mptcp/mib.c net/mptcp/mib.h net/mptcp/protocol.c +1 more+34 -13 replies
9/12mptcp: move address attribute into mptcp_addr_infonet/mptcp/pm_netlink.c net/mptcp/protocol.h net/mptcp/subflow.c+24 -241 reply
10/12mptcp: allow creating non-backup subflowsnet/mptcp/subflow.c+2 -10 replies
11/12mptcp: allow picking different xmit subflowsnet/mptcp/protocol.c net/mptcp/protocol.h+101 -175 replies
12/12mptcp: simult flow self-teststools/testing/selftests/net/mptcp/simult_flows.sh+290 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [MPTCP] [RFC PATCH 00/12] mptcp: multiple xmit substreams support

This is an early RFC to gather feedback and comments on the current status.

Needs the bugfix patch I sent before to avoid exploding badly on the first packet - can still explode after a few ones.

It refactor send space notifications, introduces OoO handling via RBtree, sndbuf autotuning, allows the PM to create non backup subflows and finally a basic scheduler and some self-tests.

The pain point is the in-window check:

on the receiver side msk rcv window is set at tcp_space(msk) - which should be a quite rough over-estimante of a more correct value.

on the sender side no limit is imposed on the xmitted sequence number, except the one given by the sndbuf. The msk sndbuf is autotuned to the subflows largest sndbuf size.

With all the above I observe several out of [MPTCP] window on the RX side, to the point that if affects the bandwidth (self-tests fail, as they basically looks at virtual link utilization).

Any comment more than welcome, especially about better mptcp window checks.

This has been quite painful, so I would propose to consider accepting on export branch even a suboptimal version and then improve incrementally.

Paolo Abeni (12):
mptcp: msk is writable according to msk write space
mptcp: set data_ready status bit in subflow_check_data_avail()
mptcp: trigger msk processing even for OoO data
mptcp: basic sndbuf autotuning
mptcp: introduce and use mptcp_try_coalesce()
mptcp: move ooo skbs into msk out of order queue.
mptcp: cleanup mptcp_subflow_discard_data()
mptcp: add OoO related mibs
mptcp: move address attribute into mptcp_addr_info
mptcp: allow creating non-backup subflows
mptcp: allow picking different xmit subflows
mptcp: simult flow self-tests

 net/mptcp/mib.c                               |   5 +
 net/mptcp/mib.h                               |   5 +
 net/mptcp/pm_netlink.c                        |  38 +-
 net/mptcp/protocol.c                          | 459 ++++++++++++++----
 net/mptcp/protocol.h                          |  18 +-
 net/mptcp/subflow.c                           |  91 ++--
 .../selftests/net/mptcp/simult_flows.sh       | 290 +++++++++++
 7 files changed, 743 insertions(+), 163 deletions(-)
 create mode 100755 tools/testing/selftests/net/mptcp/simult_flows.sh
Signature · 1 line
2.26.2