Skip to content

compiler warnings cleanup, part 1

Michal Kubecek netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7rename maybe_unused macro to __maybe_unusedamd8111e.c at76c50x-usb.c de2104x.c +25 more+36 -350 replies
2/7cable_test: clean up unused parametersnetlink/cable_test.c+8 -131 reply
3/7igc: mark unused callback parameterigc.c+2 -10 replies
4/7netlink: mark unused callback parameternetlink/netlink.c+1 -10 replies
5/7netlink: mark unused parameters of bitset walker callbacksnetlink/pause.c netlink/privflags.c netlink/settings.c +1 more+10 -60 replies
6/7netlink: mark unused parameters of parser callbacksnetlink/parser.c+16 -120 replies
7/7ioctl: avoid zero length array warning in get_stringset()ethtool.c+3 -10 replies

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by.

PatchAndrew Lunn
1/7
2/7R-b
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH ethtool 0/7] compiler warnings cleanup, part 1

Maciej Żenczykowski recently cleaned up many "unused parameter" compiler warnings but some new occurences appeared since (mostly in netlink code).

This series gets rid of all currently found "unused parameter" warnings and also one zero length array access warning (gcc10). There are still some compiler warnings left (signed/unsigned comparison and missing struct field initializers); these will be handled in next cycle as the fixes are more intrusive.

This series should not affect resulting code; checked by comparing resulting binary against unpatched source.

Michal Kubecek (7):
rename maybe_unused macro to __maybe_unused
cable_test: clean up unused parameters
igc: mark unused callback parameter
netlink: mark unused callback parameter
netlink: mark unused parameters of bitset walker callbacks
netlink: mark unused parameters of parser callbacks
ioctl: avoid zero length array warning in get_stringset()

 amd8111e.c           |  2 +-
 at76c50x-usb.c       |  2 +-
 de2104x.c            |  4 ++--
 dsa.c                |  2 +-
 e100.c               |  2 +-
 e1000.c              |  2 +-
 et131x.c             |  2 +-
 ethtool.c            | 10 ++++++----
 fec.c                |  2 +-
 fec_8xx.c            |  2 +-
 fjes.c               |  2 +-
 ibm_emac.c           |  2 +-
 igb.c                |  2 +-
 igc.c                |  3 ++-
 internal.h           |  2 +-
 ixgb.c               |  2 +-
 ixgbe.c              |  2 +-
 ixgbevf.c            |  2 +-
 lan78xx.c            |  2 +-
 marvell.c            |  4 ++--
 natsemi.c            |  4 ++--
 netlink/cable_test.c | 21 ++++++++-------------
 netlink/netlink.c    |  2 +-
 netlink/parser.c     | 28 ++++++++++++++++------------
 netlink/pause.c      |  3 ++-
 netlink/privflags.c  |  2 +-
 netlink/settings.c   |  9 ++++++---
 netlink/tsinfo.c     |  2 +-
 realtek.c            |  2 +-
 sfc.c                |  3 ++-
 smsc911x.c           |  2 +-
 stmmac.c             |  4 ++--
 tg3.c                |  4 ++--
 tse.c                |  2 +-
 vioc.c               |  2 +-
 vmxnet3.c            |  2 +-
 36 files changed, 76 insertions(+), 69 deletions(-)
Signature · 1 line
2.28.0