Skip to content

mptcp: multiple xmit substreams support

Paolo Abeni mptcp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13mptcp: rethink 'is writable' conditionalnet/mptcp/protocol.c net/mptcp/subflow.c+45 -270 replies
2/13mptcp: set data_ready status bit in subflow_check_data_avail()net/mptcp/subflow.c+8 -110 replies
3/13mptcp: trigger msk processing even for OoO datanet/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/subflow.c+78 -421 reply
4/13mptcp: basic sndbuf autotuningnet/mptcp/protocol.c+13 -40 replies
5/13mptcp: introduce and use mptcp_try_coalesce()net/mptcp/protocol.c+19 -120 replies
6/13mptcp: move ooo skbs into msk out of order queue.net/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/subflow.c+211 -560 replies
7/13mptcp: cleanup mptcp_subflow_discard_data()net/mptcp/protocol.h net/mptcp/subflow.c+12 -450 replies
8/13mptcp: add OoO related mibsnet/mptcp/mib.c net/mptcp/mib.h net/mptcp/protocol.c +1 more+34 -10 replies
9/13mptcp: move address attribute into mptcp_addr_infonet/mptcp/pm_netlink.c net/mptcp/protocol.h net/mptcp/subflow.c+24 -240 replies
10/13mptcp: allow creating non-backup subflowsnet/mptcp/subflow.c+2 -10 replies
11/13mptcp: allow picking different xmit subflowsnet/mptcp/protocol.c net/mptcp/protocol.h+104 -170 replies
12/13mptcp: simult flow self-teststools/testing/selftests/net/mptcp/simult_flows.sh+290 -00 replies
13/13mptcp: cache subflow write status in subflow ctxnet/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/subflow.c+16 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [MPTCP] [PATCH 00/13] mptcp: multiple xmit substreams support

This covers the feedback from Florian on the RFC series, please see the individual patches changelog for the details.

The only exception is: I'm retaining the MPTCP_SEND_SPACE bit, which looks required as per ML discussion.

The MPTCP window code is now more conservative and I do not see out of window errors.

Some self-tests cases are still failing - do not reach the expected aggregated bwidth - but I've not investigated yet. multiple stream self-tests are not enabled yet.

It would be great if we could starting merging this in the export branch, and improve incrementally.

Paolo Abeni (13):
mptcp: rethink 'is writable' conditional
mptcp: set data_ready status bit in subflow_check_data_avail()
mptcp: trigger msk processing even for OoO data
mptcp: basic sndbuf autotuning
mptcp: introduce and use mptcp_try_coalesce()
mptcp: move ooo skbs into msk out of order queue.
mptcp: cleanup mptcp_subflow_discard_data()
mptcp: add OoO related mibs
mptcp: move address attribute into mptcp_addr_info
mptcp: allow creating non-backup subflows
mptcp: allow picking different xmit subflows
mptcp: simult flow self-tests
mptcp: cache subflow write status in subflow ctx

 net/mptcp/mib.c                               |   5 +
 net/mptcp/mib.h                               |   5 +
 net/mptcp/pm_netlink.c                        |  38 +-
 net/mptcp/protocol.c                          | 518 ++++++++++++++----
 net/mptcp/protocol.h                          |  22 +-
 net/mptcp/subflow.c                           |  93 ++--
 .../selftests/net/mptcp/simult_flows.sh       | 290 ++++++++++
 7 files changed, 791 insertions(+), 180 deletions(-)
 create mode 100755 tools/testing/selftests/net/mptcp/simult_flows.sh
Signature · 1 line
2.26.2