Skip to content

usb: dwc3: gadget: Fix TRB preparation

Thinh Nguyen linux-usb 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 4 repliesIn review
  2. v27 patches 11 repliesSuperseded
  3. v17 patches 1 replySuperseded

Changes in v3 from the cover letter

- Rebase on Felipe's testing/next branch with the remaining patches of this series

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4usb: dwc3: gadget: Refactor preparing TRBsdrivers/usb/dwc3/gadget.c+67 -1112 replies
2/4usb: dwc3: gadget: Account for extra TRBdrivers/usb/dwc3/gadget.c+51 -312 replies
3/4usb: dwc3: gadget: Rename misleading function namesdrivers/usb/dwc3/gadget.c+5 -50 replies
4/4usb: dwc3: ep0: Skip ZLP setup for OUTdrivers/usb/dwc3/ep0.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/4] usb: dwc3: gadget: Fix TRB preparation

There are a few issues in DWC3 driver when preparing for TRB. The driver needs to account the following:

* MPS alignment for ZLP OUT direction
* Extra TRBs when checking for available TRBs
* SG entries size > request length

Along with these fixes, there are some cleanup/refactoring patches in this series.

Changes in v3:
- Rebase on Felipe's testing/next branch with the remaining patches of this series

Changes in v2:
- Update remaining length when resume request
- Remove unused variables
- Add a missing "return 0" for dwc3_prepare_trbs()
- Update doc indicating dwc3_prepare_trbs() can return other -errno

Thinh Nguyen (4):
usb: dwc3: gadget: Refactor preparing TRBs
usb: dwc3: gadget: Account for extra TRB
usb: dwc3: gadget: Rename misleading function names
usb: dwc3: ep0: Skip ZLP setup for OUT

 drivers/usb/dwc3/ep0.c    |   2 +-
 drivers/usb/dwc3/gadget.c | 246 +++++++++++++++++---------------------
 2 files changed, 112 insertions(+), 136 deletions(-)

base-commit: 8bc2602e7a402664131d79251d59b262b896ca37

Signature · 1 line
2.28.0