qga: add command guest-get-disks
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest3 patches 2 repliesIn review
- v33 patches 3 repliesSuperseded
- v23 patches 12 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 1 patch | 4 replies | Superseded |
Changes in v4 from the cover letter
- 2/3: don't leak syspath in build_guest_fsinfo_for_device()
- 3/3:
- added ERRP_GUARD
- don't loop forever when qga fails to get device information details
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | qga: add command guest-get-disksqga/ qga/ qga/ | +43 | 0 replies | |
| 2/3 | qga: add implementation of guest-get-disks for Linuxqga/ | +285 | 2 replies | |
| 3/3 | qga: add implementation of guest-get-disks for Windowsqga/ | +101 | 0 replies |
Reviews trailers per patch
2 of 3 patches have a Reviewed-by or Acked-by.
| Patch | Philippe Mathieu-Daudé | Marc-André Lureau |
|---|---|---|
| 1/3 | R-b | R-b |
| 2/3 | R-b | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/3] qga: add command guest-get-disks
Adds command to list disks of the VM.
The patch does compile on master but to work properly it requires changes to qemu-ga by Thomas Huth in series: Allow guest-get-fsinfo also for non-PCI devices.
v4:
- 2/3: don't leak syspath in build_guest_fsinfo_for_device()
- 3/3:
- added ERRP_GUARD
- don't loop forever when qga fails to get device information details
v3:
- renamed "slaves" field to "dependents"
- comments from Marc and Daniel
- 2/3: factored out pieces of code into separate functions
v2:
- added new struct in API to handle the information
- split changes into several patches
- for Linux list also slaves, partitions and virtual disks so that the disk hierarchy is preserved
- fixed issues pointed out by Michael
Tomáš Golembiovský (3):
qga: add command guest-get-disks
qga: add implementation of guest-get-disks for Linux
qga: add implementation of guest-get-disks for Windows
qga/commands-posix.c | 290 ++++++++++++++++++++++++++++++++++++++++++- qga/commands-win32.c | 101 +++++++++++++++ qga/qapi-schema.json | 31 +++++ 3 files changed, 417 insertions(+), 5 deletions(-)
Signature · 1 line
2.28.0