Skip to content

powerpc: Switch signal 32 to using unsafe_put_user() and friends

Christophe Leroy linuxppc-dev lkml oe-kbuild-all 2 versions – Applied

Status from this message: Applied to powerpc/next.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest25 patches 8 repliesApplied
  2. v1 RFC19 patches 0 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/25powerpc/signal: Move inline functions in signal.harch/powerpc/kernel/signal.c arch/powerpc/kernel/signal.h+33 -380 replies
2/25powerpc/ptrace: Move declaration of ptrace_get_reg() and ptrace_set_reg()arch/powerpc/include/asm/ptrace.h arch/powerpc/kernel/ptrace/ptrace-decl.h arch/powerpc/kernel/ptrace/ptrace32.c+5 -60 replies
3/25powerpc/ptrace: Consolidate reg index calculationarch/powerpc/kernel/ptrace/ptrace.c+4 -140 replies
4/25powerpc/ptrace: Create ptrace_get_fpr() and ptrace_put_fpr()arch/powerpc/kernel/ptrace/Makefile arch/powerpc/kernel/ptrace/ptrace-decl.h arch/powerpc/kernel/ptrace/ptrace-fpu.c +1 more+56 -290 replies
5/25powerpc/signal: Don't manage floating point regs when no FPUarch/powerpc/Kconfig arch/powerpc/include/asm/processor.h arch/powerpc/kernel/asm-offsets.c +8 more+50 -30 replies
6/25powerpc/32s: Allow deselecting CONFIG_PPC_FPU on mpc832xarch/powerpc/kernel/head_32.S arch/powerpc/platforms/Kconfig.cputype+13 -20 replies
7/25powerpc/signal: Remove BUG_ON() in handler_signal functionsarch/powerpc/kernel/signal_32.c arch/powerpc/kernel/signal_64.c+0 -60 replies
8/25powerpc/signal: Move access_ok() out of get_sigframe()arch/powerpc/kernel/signal.c arch/powerpc/kernel/signal_32.c arch/powerpc/kernel/signal_64.c+3 -70 replies
9/25powerpc/signal: Remove get_clean_sp()arch/powerpc/include/asm/processor.h arch/powerpc/kernel/signal.c+4 -150 replies
10/25powerpc/signal: Call get_tm_stackpointer() from get_sigframe()arch/powerpc/kernel/signal.c arch/powerpc/kernel/signal.h arch/powerpc/kernel/signal_32.c +1 more+11 -100 replies
11/25powerpc/signal: Refactor bad frame loggingarch/powerpc/kernel/signal.c arch/powerpc/kernel/signal.h arch/powerpc/kernel/signal_32.c +1 more+21 -431 reply
12/25powerpc/signal32: Simplify logging in handle_rt_signal32()arch/powerpc/kernel/signal_32.c+1 -50 replies
13/25powerpc/signal32: Move handle_signal32() close to handle_rt_signal32()arch/powerpc/kernel/signal_32.c+85 -850 replies
14/25powerpc/signal32: Rename local pointers in handle_rt_signal32()arch/powerpc/kernel/signal_32.c+25 -260 replies
15/25powerpc/signal32: Misc changes to make handle_[rt_]_signal32() more similararch/powerpc/kernel/signal_32.c+14 -100 replies
16/25powerpc/signal32: Move signal trampoline setup to handle_[rt_]signal32arch/powerpc/kernel/signal_32.c+22 -390 replies
17/25powerpc/signal32: Switch handle_signal32() to user_access_begin() logicarch/powerpc/kernel/signal_32.c+16 -130 replies
18/25powerpc/signal32: Switch handle_rt_signal32() to user_access_begin() logicarch/powerpc/kernel/signal_32.c+34 -210 replies
19/25powerpc/signal32: Remove ifdefery in middle of if/elsearch/powerpc/kernel/signal_32.c+8 -140 replies
20/25signal: Add unsafe_put_compat_sigset()include/linux/compat.h+32 -00 replies
21/25powerpc/signal32: Add and use unsafe_put_sigset_t()arch/powerpc/kernel/signal_32.c+11 -20 replies
22/25powerpc/signal32: Switch swap_context() to user_access_begin() logicarch/powerpc/kernel/signal_32.c+10 -140 replies
23/25powerpc/signal: Create 'unsafe' versions of copy_[ck][fpr/vsx]_to_user()arch/powerpc/kernel/signal.h+53 -03 replies
24/25powerpc/signal32: Isolate non-copy actions in save_user_regs() and save_tm_user_regs()arch/powerpc/kernel/signal_32.c+41 -130 replies
25/25powerpc/signal32: Transform save_user_regs() and save_tm_user_regs() in 'unsafe' versionarch/powerpc/kernel/signal_32.c+111 -1133 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/25] powerpc: Switch signal 32 to using unsafe_put_user() and friends

This series leads to a reduction from 2.55s to 1.73s of the system CPU time with the following microbench app on an mpc832x with KUAP (approx 32%)

This series replaces copies to users by unsafe_put_user() and friends with user_write_access_begin() dance in signal32.

The advantages are:
- No KUAP unlock/lock at every copy
- More readable code.
- Better generated code.

Without KUAP, the difference is in the noise.

	void sigusr1(int sig) { }

	int main(int argc, char **argv)
	{
		int i = 100000;

		signal(SIGUSR1, sigusr1);
		for (;i--;)
		    raise(SIGUSR1);
		exit(0);
	}

An additional 0.10s reduction is achieved by removing CONFIG_PPC_FPU, as the mpc832x has no FPU.

A bit less spectacular on an 8xx as KUAP is less heavy, prior to the series (with KUAP) it ran in 8.10 ms. Once applies the removal of FPU regs handling, we get 7.05s. With the full series, we get 6.9s. If artificially re-activating FPU regs handling with the full series, we get 7.6s.

So for the 8xx, the removal of the FPU regs copy is what makes the difference, but the rework of handle_signal also have a benefit.

Same as above, without KUAP the difference is in the noise.

Difference since v1(RFC):
- Almost copies to user are now replaced by unsafe_ alternative.
- Reworked a bit the FPU registers handling following feedback from Michael.
- Fixed a few build failures reported by Mr Robot on the RFC.

Christophe Leroy (25):
powerpc/signal: Move inline functions in signal.h powerpc/ptrace: Move declaration of ptrace_get_reg() and
ptrace_set_reg()
powerpc/ptrace: Consolidate reg index calculation powerpc/ptrace: Create ptrace_get_fpr() and ptrace_put_fpr() powerpc/signal: Don't manage floating point regs when no FPU powerpc/32s: Allow deselecting CONFIG_PPC_FPU on mpc832x powerpc/signal: Remove BUG_ON() in handler_signal functions powerpc/signal: Move access_ok() out of get_sigframe() powerpc/signal: Remove get_clean_sp()
powerpc/signal: Call get_tm_stackpointer() from get_sigframe() powerpc/signal: Refactor bad frame logging powerpc/signal32: Simplify logging in handle_rt_signal32() powerpc/signal32: Move handle_signal32() close to handle_rt_signal32() powerpc/signal32: Rename local pointers in handle_rt_signal32() powerpc/signal32: Misc changes to make handle_[rt_]_signal32() more
similar
powerpc/signal32: Move signal trampoline setup to handle_[rt_]signal32 powerpc/signal32: Switch handle_signal32() to user_access_begin()
logic
powerpc/signal32: Switch handle_rt_signal32() to user_access_begin()
logic
powerpc/signal32: Remove ifdefery in middle of if/else
signal: Add unsafe_put_compat_sigset()
powerpc/signal32: Add and use unsafe_put_sigset_t() powerpc/signal32: Switch swap_context() to user_access_begin() logic powerpc/signal: Create 'unsafe' versions of

    copy_[ck][fpr/vsx]_to_user()
  powerpc/signal32: Isolate non-copy actions in save_user_regs() and
    save_tm_user_regs()

powerpc/signal32: Transform save_user_regs() and save_tm_user_regs()
in 'unsafe' version

 arch/powerpc/Kconfig                     |   1 +
 arch/powerpc/include/asm/processor.h     |  16 +-
 arch/powerpc/include/asm/ptrace.h        |   6 -
 arch/powerpc/kernel/asm-offsets.c        |   2 +
 arch/powerpc/kernel/head_32.S            |   4 +
 arch/powerpc/kernel/process.c            |   4 +
 arch/powerpc/kernel/ptrace/Makefile      |   3 +-
 arch/powerpc/kernel/ptrace/ptrace-decl.h |  21 +
 arch/powerpc/kernel/ptrace/ptrace-fpu.c  |  40 ++
 arch/powerpc/kernel/ptrace/ptrace-view.c |   2 +
 arch/powerpc/kernel/ptrace/ptrace.c      |  54 +-
 arch/powerpc/kernel/ptrace/ptrace32.c    |   2 +
 arch/powerpc/kernel/signal.c             |  59 +--
 arch/powerpc/kernel/signal.h             | 115 ++++-
 arch/powerpc/kernel/signal_32.c          | 598 +++++++++++------------
 arch/powerpc/kernel/signal_64.c          |  21 +-
 arch/powerpc/kernel/traps.c              |   2 +
 arch/powerpc/platforms/Kconfig.cputype   |  15 +-
 include/linux/compat.h                   |  32 ++
 19 files changed, 566 insertions(+), 431 deletions(-)
 create mode 100644 arch/powerpc/kernel/ptrace/ptrace-fpu.c
Signature · 1 line
2.25.0