Skip to content

DRM driver for Hikey 970

Mauro Carvalho Chehab bpf dri-devel linux-arm-kernel linux-devicetree linux-media lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest49 patches 50 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/49staging: hikey9xx: Add hisilicon DRM driver for hikey960/970drivers/staging/hikey9xx/gpu/Kconfig drivers/staging/hikey9xx/gpu/Makefile drivers/staging/hikey9xx/gpu/dw_drm_dsi.c +10 more+8755 -00 replies
2/49staging: hikey9xx/gpu: port it to work with Kernel v4.9drivers/staging/hikey9xx/gpu/dw_drm_dsi.c drivers/staging/hikey9xx/gpu/kirin_dpe_reg.h drivers/staging/hikey9xx/gpu/kirin_drm_drv.c +3 more+30 -320 replies
3/49staging: hikey9xx/gpu: solve tearing issue of displaydrivers/staging/hikey9xx/gpu/dw_drm_dsi.c drivers/staging/hikey9xx/gpu/kirin_drm_dss.c drivers/staging/hikey9xx/gpu/kirin_drm_overlay_utils.c+41 -560 replies
4/49staging: hikey9xx/gpu: resolve the performance issue by interrupt mechanismdrivers/staging/hikey9xx/gpu/kirin_dpe_reg.h drivers/staging/hikey9xx/gpu/kirin_drm_dpe_utils.c drivers/staging/hikey9xx/gpu/kirin_drm_dss.c +1 more+20 -570 replies
5/49staging: hikey9xx/gpu: add support to hikey970 HDMI and paneldrivers/staging/hikey9xx/gpu/Makefile drivers/staging/hikey9xx/gpu/dw_drm_dsi.c drivers/staging/hikey9xx/gpu/hdmi/adv7535.c +14 more+8938 -1520 replies
6/49staging: hikey9xx/gpu: Solve SR Cannot Display Problems.drivers/staging/hikey9xx/gpu/dw_drm_dsi.c drivers/staging/hikey9xx/gpu/hdmi/adv7535.c drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h +8 more+401 -600 replies
7/49staging: hikey9xx/gpu: Solve HDMI compatibility Problem.drivers/staging/hikey9xx/gpu/dw_drm_dsi.c drivers/staging/hikey9xx/gpu/hdmi/adv7535.c drivers/staging/hikey9xx/gpu/kirin_drm_dpe_utils.c +6 more+41 -1980 replies
8/49staging: hikey9xx/gpu: Support MIPI DSI 3 lanes for hikey970.drivers/staging/hikey9xx/gpu/dw_drm_dsi.c drivers/staging/hikey9xx/gpu/hdmi/adv7535.c drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h+16 -130 replies
9/49staging: hikey9xx/gpu: Solve SR test reset problem for hikey970.drivers/staging/hikey9xx/gpu/Makefile drivers/staging/hikey9xx/gpu/dw_drm_dsi.c drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h +5 more+85 -600 replies
10/49staging: hikey9xx/gpu: add debug prints for this driverdrivers/staging/hikey9xx/gpu/hdmi/adv7535.c drivers/staging/hikey9xx/gpu/kirin_drm_drv.c+37 -51 reply
11/49staging: hikey9xx/gpu: Add support 10.1 inch special HDMI displays.drivers/staging/hikey9xx/gpu/kirin_drm_dss.c+4 -00 replies
12/49staging: hikey9xx/gpu: get rid of adv7535 forkdrivers/staging/hikey9xx/gpu/hdmi/adv7535.c drivers/staging/hikey9xx/gpu/hdmi/adv7535.h drivers/staging/hikey9xx/gpu/hdmi/adv7535_audio.c+0 -23420 replies
13/49staging: hikey9xx/gpu: rename the Kirin9xx namespacedrivers/staging/hikey9xx/gpu/kirin9xx_dpe_reg.h drivers/staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.c drivers/staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.h +10 more+0 -00 replies
14/49staging: hikey9xx/gpu: get rid of kirin9xx_fbdev.cdrivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.c drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.h drivers/staging/hikey9xx/gpu/kirin9xx_fb.c +1 more+1 -5910 replies
15/49staging: hikey9xx/gpu: get rid of some ifdefsdrivers/staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.c drivers/staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.h drivers/staging/hikey9xx/gpu/kirin9xx_drm_overlay_utils.c+0 -540 replies
16/49staging: hikey9xx/gpu: rename the config option for Kirin970drivers/staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.c drivers/staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.h drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c +1 more+9 -90 replies
17/49staging: hikey9xx/gpu: change the includes to reflect upstreamdrivers/staging/hikey9xx/gpu/kirin960_dpe_reg.h drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h drivers/staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.c +7 more+51 -350 replies
18/49staging: hikey9xx/gpu: port driver to upstream kAPIsdrivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.c drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c drivers/staging/hikey9xx/gpu/kirin9xx_drm_overlay_utils.c +1 more+57 -890 replies
19/49staging: hikey9xx/gpu: add a copy of set_reg() function theredrivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c+16 -10 replies
20/49staging: hikey9xx/gpu: get rid of ION headersdrivers/staging/hikey9xx/gpu/kirin960_dpe_reg.h drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.h+0 -80 replies
21/49staging: hikey9xx/gpu: add support for using a reserved CMA memorydrivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.c drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.h drivers/staging/hikey9xx/gpu/kirin9xx_drm_overlay_utils.c+13 -430 replies
22/49staging: hikey9xx/gpu: cleanup encoder attach logicdrivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c+31 -270 replies
23/49staging: hikey9xx/gpu: Change the logic which sets the burst modedrivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c+20 -140 replies
24/49staging: hikey9xx/gpu: fix the DRM setting logicdrivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c+19 -190 replies
25/49staging: hikey9xx/gpu: do some code cleanupsdrivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.c+30 -513 replies
26/49staging: hikey9xx/gpu: use default GEM_CMA fopsdrivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.c+1 -130 replies
27/49staging: hikey9xx/gpu: place vblank enable/disable at the right placedrivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c+11 -100 replies
28/49staging: hikey9xx/gpu: remove an uneeded hackdrivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.c+0 -50 replies
29/49staging: hikey9xx/gpu: add a possible implementation for atomic_disabledrivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c+8 -10 replies
30/49staging: hikey9xx/gpu: register connectordrivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c+2 -00 replies
31/49staging: hikey9xx/gpu: fix driver namedrivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c+1 -10 replies
32/49staging: hikey9xx/gpu: get rid of iommu_formatdrivers/staging/hikey9xx/gpu/kirin960_dpe_reg.h drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.h+0 -40 replies
33/49staging: hikey9xx/gpu: re-work the mode validation codedrivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c+211 -970 replies
34/49staging: hikey9xx/gpu: add support for enable/disable ldo3 regulatordrivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h drivers/staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.c drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c +1 more+5 -170 replies
35/49staging: hikey9xx/gpu: add SPMI headersdrivers/staging/hikey9xx/gpu/kirin960_dpe_reg.h drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h drivers/staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.c +9 more+43 -340 replies
36/49staging: hikey9xx/gpu: solve most coding style issuesdrivers/staging/hikey9xx/gpu/kirin960_dpe_reg.h drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h drivers/staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.c +8 more+1140 -11420 replies
37/49staging: hikey9xx/gpu: don't use iommu codedrivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c drivers/staging/hikey9xx/gpu/kirin9xx_drm_overlay_utils.c+20 -20 replies
38/49staging: hikey9xx/gpu: add kirin9xx driver to the building systemdrivers/staging/hikey9xx/Kconfig drivers/staging/hikey9xx/Makefile drivers/staging/hikey9xx/gpu/Kconfig +1 more+22 -551 reply
39/49staging: hikey9xx/gpu: get rid of typedefsdrivers/staging/hikey9xx/gpu/kirin960_dpe_reg.h drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h drivers/staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.c +3 more+130 -1290 replies
40/49staging: hikey9xx/gpu: get rid of input/output macrosdrivers/staging/hikey9xx/gpu/kirin960_dpe_reg.h drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h drivers/staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.c +4 more+180 -1830 replies
41/49staging: hikey9xx/gpu: get rid of some unused datadrivers/staging/hikey9xx/gpu/kirin960_dpe_reg.h drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c+0 -70 replies
42/49staging: hikey9xx/gpu: place common definitions at kirin9xx_dpe.hdrivers/gpu/drm/hisilicon/kirin/kirin9xx_dpe.h drivers/staging/hikey9xx/gpu/kirin960_dpe_reg.h drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h +5 more+2653 -60490 replies
43/49staging: hikey9xx/gpu: get rid of DRM_HISI_KIRIN970drivers/staging/hikey9xx/gpu/Makefile drivers/staging/hikey9xx/gpu/kirin960_defs.c drivers/staging/hikey9xx/gpu/kirin960_dpe_reg.h +11 more+1074 -9690 replies
44/49dts: hisilicon: hi3670.dtsi: add I2C settingsarch/arm64/boot/dts/hisilicon/hi3670.dtsi+71 -00 replies
45/49dts: hikey970-pinctrl.dtsi: add missing pinctrl settingsarch/arm64/boot/dts/hisilicon/hikey970-pinctrl.dtsi+537 -110 replies
46/49dt: hisilicon: add support for the PMIC found on Hikey 970arch/arm64/boot/dts/hisilicon/hi3670-hikey970.dts arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi+200 -190 replies
47/49dts: add support for Hikey 970 DRMarch/arm64/boot/dts/hisilicon/hi3670-hikey970.dts arch/arm64/boot/dts/hisilicon/hi3670.dtsi arch/arm64/boot/dts/hisilicon/hikey970-drm.dtsi+188 -00 replies
48/49staging: hikey9xx/gpu: drop kirin9xx_pwmarch/arm64/boot/dts/hisilicon/hikey970-drm.dtsi drivers/staging/hikey9xx/gpu/Makefile drivers/staging/hikey9xx/gpu/kirin9xx_pwm.c+1 -4420 replies
49/49dt: display: Add binds for the DPE and DSI controller for Kirin 960/970Documentation/devicetree/bindings/display/hisilicon,hi3660-dpe.yaml Documentation/devicetree/bindings/display/hisilicon,hi3660-dsi.yaml arch/arm64/boot/dts/hisilicon/hikey970-drm.dtsi+203 -22 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/49] DRM driver for Hikey 970

This patch series port the out-of-tree driver for Hikey 970 (which should also support Hikey 960) from the official 96boards tree:

https://github.com/96boards-hikey/linux/tree/hikey970-v4.9

Based on his history, this driver seems to be originally written for Kernel 4.4, and was later ported to Kernel 4.9. The original driver used to depend on ION (from Kernel 4.4) and had its own implementation for FB dev API.

As I need to preserve the original history (with has patches from both HiSilicon and from Linaro), I'm starting from the original patch applied there. The remaining patches are incremental, and port this driver to work with upstream Kernel.

This driver doesn't depend on any firmware or on any special userspace code. It works as-is with both X11 and Wayland.

Yet, I'm submitting it via staging due to the following reasons:

- It depends on the LDO3 power supply, which is provided by a regulator driver that it is currently on staging;
- Due to legal reasons, I need to preserve the authorship of each one responsbile for each patch. So, I need to start from the original patch from Kernel 4.4;
- There are still some problems I need to figure out how to solve:
- The adv7535 can't get EDID data. Maybe it is a timing issue,

     but it requires more research to be sure about how to solve it;

- The driver only accept resolutions on a defined list, as there's a known bug that this driver may have troubles with random resolutions. Probably due to a bug at the pixel clock settings;
- Sometimes (at least with 1080p), it generates LDI underflow errors, which in turn causes the DRM to stop working. That happens for example when using gdm on Wayland and gnome on X11;
- Probably related to the previous issue, when the monitor suspends due to DPMS, it doesn't return back to life.

So, IMO, the best is to keep it on staging for a while, until those remaining bugs gets solved.

I added this series, together with the regulator driver and a few other patches (including a hack to fix a Kernel 5.8 regression at WiFi ) at:

https://gitlab.freedesktop.org/mchehab_kernel/hikey-970/-/commits/master

Chen Feng (1):
staging: hikey9xx: Add hisilicon DRM driver for hikey960/970

John Stultz (1):
staging: hikey9xx/gpu: port it to work with Kernel v4.9

Liwei Cai (2):
staging: hikey9xx/gpu: solve tearing issue of display
staging: hikey9xx/gpu: resolve the performance issue by interrupt
mechanism

Mauro Carvalho Chehab (38):
staging: hikey9xx/gpu: get rid of adv7535 fork
staging: hikey9xx/gpu: rename the Kirin9xx namespace
staging: hikey9xx/gpu: get rid of kirin9xx_fbdev.c
staging: hikey9xx/gpu: get rid of some ifdefs
staging: hikey9xx/gpu: rename the config option for Kirin970
staging: hikey9xx/gpu: change the includes to reflect upstream
staging: hikey9xx/gpu: port driver to upstream kAPIs
staging: hikey9xx/gpu: add a copy of set_reg() function there
staging: hikey9xx/gpu: get rid of ION headers
staging: hikey9xx/gpu: add support for using a reserved CMA memory
staging: hikey9xx/gpu: cleanup encoder attach logic
staging: hikey9xx/gpu: Change the logic which sets the burst mode
staging: hikey9xx/gpu: fix the DRM setting logic
staging: hikey9xx/gpu: do some code cleanups
staging: hikey9xx/gpu: use default GEM_CMA fops
staging: hikey9xx/gpu: place vblank enable/disable at the right place
staging: hikey9xx/gpu: remove an uneeded hack
staging: hikey9xx/gpu: add a possible implementation for
atomic_disable
staging: hikey9xx/gpu: register connector
staging: hikey9xx/gpu: fix driver name
staging: hikey9xx/gpu: get rid of iommu_format
staging: hikey9xx/gpu: re-work the mode validation code
staging: hikey9xx/gpu: add support for enable/disable ldo3 regulator
staging: hikey9xx/gpu: add SPMI headers
staging: hikey9xx/gpu: solve most coding style issues
staging: hikey9xx/gpu: don't use iommu code
staging: hikey9xx/gpu: add kirin9xx driver to the building system
staging: hikey9xx/gpu: get rid of typedefs
staging: hikey9xx/gpu: get rid of input/output macros
staging: hikey9xx/gpu: get rid of some unused data
staging: hikey9xx/gpu: place common definitions at kirin9xx_dpe.h
staging: hikey9xx/gpu: get rid of DRM_HISI_KIRIN970
dts: hisilicon: hi3670.dtsi: add I2C settings
dts: hikey970-pinctrl.dtsi: add missing pinctrl settings
dt: hisilicon: add support for the PMIC found on Hikey 970
dts: add support for Hikey 970 DRM
staging: hikey9xx/gpu: drop kirin9xx_pwm
dt: display: Add binds for the DPE and DSI controller for Kirin

    960/970

Xiubin Zhang (7):
staging: hikey9xx/gpu: add support to hikey970 HDMI and panel
staging: hikey9xx/gpu: Solve SR Cannot Display Problems.
staging: hikey9xx/gpu: Solve HDMI compatibility Problem.
staging: hikey9xx/gpu: Support MIPI DSI 3 lanes for hikey970.
staging: hikey9xx/gpu: Solve SR test reset problem for hikey970.
staging: hikey9xx/gpu: add debug prints for this driver
staging: hikey9xx/gpu: Add support 10.1 inch special HDMI displays.

 .../display/hisilicon,hi3660-dpe.yaml         |   99 +
 .../display/hisilicon,hi3660-dsi.yaml         |  102 +
 .../boot/dts/hisilicon/hi3670-hikey970.dts    |   56 +-
 arch/arm64/boot/dts/hisilicon/hi3670.dtsi     |   77 +
 .../boot/dts/hisilicon/hikey970-drm.dtsi      |   93 +
 .../boot/dts/hisilicon/hikey970-pinctrl.dtsi  |  548 +++-
 .../boot/dts/hisilicon/hikey970-pmic.dtsi     |  197 ++
 drivers/staging/hikey9xx/Kconfig              |    3 +
 drivers/staging/hikey9xx/Makefile             |    1 +
 drivers/staging/hikey9xx/gpu/Kconfig          |   22 +
 drivers/staging/hikey9xx/gpu/Makefile         |    9 +
 drivers/staging/hikey9xx/gpu/kirin960_defs.c  |  378 +++
 .../staging/hikey9xx/gpu/kirin960_dpe_reg.h   |  233 ++
 drivers/staging/hikey9xx/gpu/kirin970_defs.c  |  381 +++
 .../staging/hikey9xx/gpu/kirin970_dpe_reg.h   | 1188 ++++++++
 drivers/staging/hikey9xx/gpu/kirin9xx_dpe.h   | 2437 +++++++++++++++++
 .../hikey9xx/gpu/kirin9xx_drm_dpe_utils.c     | 1178 ++++++++
 .../hikey9xx/gpu/kirin9xx_drm_dpe_utils.h     |  286 ++
 .../staging/hikey9xx/gpu/kirin9xx_drm_drv.c   |  368 +++
 .../staging/hikey9xx/gpu/kirin9xx_drm_drv.h   |   57 +
 .../staging/hikey9xx/gpu/kirin9xx_drm_dss.c   | 1063 +++++++
 .../hikey9xx/gpu/kirin9xx_drm_overlay_utils.c | 1005 +++++++
 .../hikey9xx/gpu/kirin9xx_dw_drm_dsi.c        | 2132 ++++++++++++++
 .../hikey9xx/gpu/kirin9xx_dw_dsi_reg.h        |  146 +
 .../staging/hikey9xx/gpu/kirin9xx_fb_panel.h  |  191 ++
 25 files changed, 12229 insertions(+), 21 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/display/hisilicon,hi3660-dpe.yaml
 create mode 100644 Documentation/devicetree/bindings/display/hisilicon,hi3660-dsi.yaml
 create mode 100644 arch/arm64/boot/dts/hisilicon/hikey970-drm.dtsi
 create mode 100644 arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi
 create mode 100644 drivers/staging/hikey9xx/gpu/Kconfig
 create mode 100644 drivers/staging/hikey9xx/gpu/Makefile
 create mode 100644 drivers/staging/hikey9xx/gpu/kirin960_defs.c
 create mode 100644 drivers/staging/hikey9xx/gpu/kirin960_dpe_reg.h
 create mode 100644 drivers/staging/hikey9xx/gpu/kirin970_defs.c
 create mode 100644 drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h
 create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_dpe.h
 create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.c
 create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.h
 create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.c
 create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.h
 create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c
 create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_drm_overlay_utils.c
 create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c
 create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_dw_dsi_reg.h
 create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_fb_panel.h
Signature · 7 lines
2.26.2


_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel