Skip to content

Lockdep fixes

Josef Bacik linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8btrfs: drop path before adding new uuid tree entryfs/btrfs/volumes.c+2 -10 replies
2/8btrfs: fix potential deadlock in the search ioctlfs/btrfs/extent_io.c fs/btrfs/extent_io.h fs/btrfs/ioctl.c+27 -140 replies
3/8btrfs: move btrfs_scratch_superblocks into btrfs_dev_replace_finishingfs/btrfs/dev-replace.c fs/btrfs/volumes.c fs/btrfs/volumes.h+9 -91 reply
4/8btrfs: move btrfs_rm_dev_replace_free_srcdev outside of all locksfs/btrfs/dev-replace.c fs/btrfs/volumes.c+5 -10 replies
5/8btrfs: do not hold device_list_mutex when closing devicesfs/btrfs/volumes.c+3 -40 replies
6/8btrfs: allocate scrub workqueues outside of locksfs/btrfs/scrub.c+70 -520 replies
7/8btrfs: set the correct lockdep class for new nodesfs/btrfs/extent-tree.c+1 -11 reply
8/8btrfs: set the lockdep class for log tree extent buffersfs/btrfs/ctree.c+5 -11 reply

Reviews trailers per patch

3 of 8 patches have a Reviewed-by or Acked-by.

PatchNikolay Borisov
1/8
2/8
3/8R-b
4/8
5/8
6/8
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] Lockdep fixes

Hello,

While reworking the btrfs locking to use a rwsem I discovered a few more lockdep issues because of the new locking. These are stand alone fixes that are safe enough to go into 5.9, so I've broken them out from the overall locking rework. I addressed the issues that Filipe pointed out (I think I did anyway), and run the whole series through xfstests and saw no more lockdep messages.

fs/btrfs/ctree.c | 6 +-

 fs/btrfs/dev-replace.c |   6 +-
 fs/btrfs/extent-tree.c |   2 +-
 fs/btrfs/extent_io.c   |   8 +--
 fs/btrfs/extent_io.h   |   6 +-
 fs/btrfs/ioctl.c       |  27 ++++++---
 fs/btrfs/scrub.c       | 122 +++++++++++++++++++++++------------------
 fs/btrfs/volumes.c     |  23 ++++----
 fs/btrfs/volumes.h     |   3 +
 9 files changed, 121 insertions(+), 82 deletions(-)

Thanks,

Josef