Refactor generic fastboot_set_reboot_flag implementation
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest7 patches 0 repliesNew
- v1 posting 2/27 patches 0 repliesSuperseded
- v1 posting 1/27 patches 0 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | cmd: bcb: Extract '__bcb_load' from 'do_bcb_load' for internal needscmd/ | +23 | 0 replies | |
| 2/7 | cmd: bcb: Extract '__bcb_set' from 'do_bcb_set' for internal needscmd/ | +11 | 0 replies | |
| 3/7 | cmd: bcb: Extract '__bcb_store' from 'do_bcb_store' for internal needscmd/ | +7 | 0 replies | |
| 4/7 | cmd: bcb: Expose 'bcb_write_reboot_reason' to external callerscmd/ include/ | +42 | 0 replies | |
| 5/7 | cmd: bcb: Add support for processing const string literals in bcb_set()cmd/ include/ | +14 | 0 replies | |
| 6/7 | Revert "fastboot: Add default fastboot_set_reboot_flag implementation"drivers/ drivers/ drivers/ +1 more | +0 | 0 replies | |
| 7/7 | fastboot: Implement generic fastboot_set_reboot_flagdrivers/ | +15 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/7] Refactor generic fastboot_set_reboot_flag implementation
Current generic implementation of fastboot_set_reboot_flag is somewhat messy and requires some additional configuration option to be enabled besides CMD_BCB, so it reverts that implementtion in order to bring a new cleaner one.
New function called bcb_set_reboot_reason should be exposed by BCB commands, so that all of the details could be put there instead of dealing with it in fastboot implementation directly. After that, fastboot_set_reboot_flag could simply pass correct reboot reason string to the BCB implementation. If CMD_BCB is disabled then the whole operation would return error code, which is no different behaviour than the current implementation.
Changes since v1[1]
* Fixed compilation issue for sandbox platform caused by undefined FASTBOOT_FLASH_MMC_DEV Kconfig option.
* Fixed compilation issue in bcb.h caused by missing common.h header for sandbox platform
[1]: https://patchwork.ozlabs.org/project/uboot/cover/cover.1603442753.git.roman.kovalivskyi at globallogic.com/
Eugeniu Rosca (5):
cmd: bcb: Extract '__bcb_load' from 'do_bcb_load' for internal needs
cmd: bcb: Extract '__bcb_set' from 'do_bcb_set' for internal needs
cmd: bcb: Extract '__bcb_store' from 'do_bcb_store' for internal needs
cmd: bcb: Expose 'bcb_write_reboot_reason' to external callers
cmd: bcb: Add support for processing const string literals in
bcb_set()
Roman Kovalivskyi (2):
Revert "fastboot: Add default fastboot_set_reboot_flag implementation"
fastboot: Implement generic fastboot_set_reboot_flag
cmd/bcb.c | 88 +++++++++++++++++++++++++++------- drivers/fastboot/Kconfig | 12 ----- drivers/fastboot/Makefile | 1 - drivers/fastboot/fb_bcb_impl.c | 43 ----------------- drivers/fastboot/fb_common.c | 16 ++++++- include/bcb.h | 22 +++++++++ include/fastboot.h | 9 ---- 7 files changed, 107 insertions(+), 84 deletions(-) delete mode 100644 drivers/fastboot/fb_bcb_impl.c create mode 100644 include/bcb.h
Signature · 1 line
2.17.1