Skip to content

more miscellaneous Bloom filter improvements, redux

Taylor Blau git 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest13 patches 6 repliesIn review
  2. v213 patches 13 repliesSuperseded
  3. v112 patches 15 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13commit-graph: introduce 'get_bloom_filter_settings()'blame.c bloom.c commit-graph.c +4 more+40 -120 replies
2/13t4216: use an '&&'-chaint/t4216-log-bloom.sh+1 -10 replies
3/13commit-graph: pass a 'struct repository *' in more placesbuiltin/commit-graph.c commit-graph.c commit-graph.h +1 more+18 -120 replies
4/13t/helper/test-read-graph.c: prepare repo settingst/helper/test-read-graph.c+2 -10 replies
5/13commit-graph: respect 'commitGraph.readChangedPaths'Documentation/config.txt Documentation/config/commitgraph.txt commit-graph.c +3 more+17 -30 replies
6/13commit-graph.c: store maximum changed pathsbloom.h commit-graph.c t/t4216-log-bloom.sh+16 -30 replies
7/13bloom: split 'get_bloom_filter()' in twoblame.c bloom.c bloom.h +4 more+62 -130 replies
8/13bloom: use provided 'struct bloom_filter_settings'bloom.c bloom.h commit-graph.c +1 more+19 -192 replies
9/13bloom/diff: properly short-circuit on max_changesbloom.c diff.h t/t4216-log-bloom.sh +1 more+100 -160 replies
10/13bloom: encode out-of-bounds filters as non-emptyDocumentation/technical/commit-graph-format.txt bloom.c bloom.h +3 more+54 -90 replies
11/13commit-graph: rename 'split_commit_graph_opts'builtin/commit-graph.c commit-graph.c commit-graph.h+34 -340 replies
12/13builtin/commit-graph.c: introduce '--max-new-filters=<n>'Documentation/git-commit-graph.txt bloom.c builtin/commit-graph.c +3 more+111 -80 replies
13/13commit-graph: introduce 'commitGraph.maxNewFilters'Documentation/config/commitgraph.txt Documentation/git-commit-graph.txt builtin/commit-graph.c +1 more+43 -22 replies

Reviews trailers per patch

None of the 13 patches has a Reviewed-by or Acked-by.

PatchDerrick StoleeEric SunshineJeff KingSZEDER GáborJunio C Hamano
1/13Co-authored-by
2/13Helped-by Helped-by
3/13
4/13
5/13
6/13
7/13
8/13
9/13
10/13Helped-by Helped-by Helped-by
11/13
12/13Helped-by
13/13Helped-by Helped-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/13] more miscellaneous Bloom filter improvements, redux

Hi again,

Here's a few more changes to the "Bloom filter improvements" topic, sent as one brand-new re-roll in order to simplify queuing. It incorporates:

- Junio's changes from applying to 'seen' (namely, dropping references to "too-small" commits in favor of the much more clear "empty" commits).

- On top, I applied Gàbor's data gathered in [1] to 10/13 (and added a little more detail on the absolute and relative size differences of the resulting commit-graph files built before/after that patch).

Thanks to everyone who has helped out along the way with this series (Stolee, Gàbor, Junio, Jakub, and I am sure that I am forgetting some...).

Sorry to have given anyone the impression that I was abandoning this topic; I'm definitely not ;-).

[1]: https://lore.kernel.org/git/[email protected]/

Derrick Stolee (1):
bloom/diff: properly short-circuit on max_changes

Taylor Blau (12):
commit-graph: introduce 'get_bloom_filter_settings()'
t4216: use an '&&'-chain
commit-graph: pass a 'struct repository *' in more places t/helper/test-read-graph.c: prepare repo settings
commit-graph: respect 'commitGraph.readChangedPaths' commit-graph.c: store maximum changed paths
bloom: split 'get_bloom_filter()' in two
bloom: use provided 'struct bloom_filter_settings'
bloom: encode out-of-bounds filters as non-empty
commit-graph: rename 'split_commit_graph_opts' builtin/commit-graph.c: introduce '--max-new-filters=<n>'
commit-graph: introduce 'commitGraph.maxNewFilters'

 Documentation/config.txt                      |   2 +
 Documentation/config/commitgraph.txt          |   8 +
 Documentation/git-commit-graph.txt            |   6 +
 .../technical/commit-graph-format.txt         |   2 +-
 blame.c                                       |   8 +-
 bloom.c                                       |  59 +++--
 bloom.h                                       |  29 ++-
 builtin/commit-graph.c                        |  63 ++++-
 commit-graph.c                                | 141 +++++++---
 commit-graph.h                                |  17 +-
 diff.h                                        |   2 -
 fuzz-commit-graph.c                           |   5 +-
 line-log.c                                    |   2 +-
 repo-settings.c                               |   3 +
 repository.h                                  |   1 +
 revision.c                                    |   7 +-
 t/helper/test-bloom.c                         |   4 +-
 t/helper/test-read-graph.c                    |   3 +-
 t/t0095-bloom.sh                              |   8 +-
 t/t4216-log-bloom.sh                          | 242 ++++++++++++++++--
 t/t5324-split-commit-graph.sh                 |  13 +
 tree-diff.c                                   |   5 +-
 22 files changed, 507 insertions(+), 123 deletions(-)
 create mode 100644 Documentation/config/commitgraph.txt

--
2.28.0.510.g375ecf1f36