Skip to content

mptcp: introduce support for real multipath xmit

Paolo Abeni mptcp netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 13 repliesIn review
  2. v113 patches 1 replySuperseded

Changes in v2 from the cover letter

- fix 32 bit build breakage
- fix a bunch of checkpatch issues

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13mptcp: rethink 'is writable' conditionalnet/mptcp/protocol.c net/mptcp/subflow.c+50 -271 reply
2/13mptcp: set data_ready status bit in subflow_check_data_avail()net/mptcp/subflow.c+8 -111 reply
3/13mptcp: trigger msk processing even for OoO datanet/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/subflow.c+78 -421 reply
4/13mptcp: basic sndbuf autotuningnet/mptcp/protocol.c+13 -41 reply
5/13mptcp: introduce and use mptcp_try_coalesce()net/mptcp/protocol.c+19 -121 reply
6/13mptcp: move ooo skbs into msk out of order queue.net/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/subflow.c+211 -561 reply
7/13mptcp: cleanup mptcp_subflow_discard_data()net/mptcp/protocol.h net/mptcp/subflow.c+14 -451 reply
8/13mptcp: add OoO related mibsnet/mptcp/mib.c net/mptcp/mib.h net/mptcp/protocol.c +1 more+34 -11 reply
9/13mptcp: move address attribute into mptcp_addr_infonet/mptcp/pm_netlink.c net/mptcp/protocol.h net/mptcp/subflow.c+25 -241 reply
10/13mptcp: allow creating non-backup subflowsnet/mptcp/subflow.c+2 -11 reply
11/13mptcp: allow picking different xmit subflowsnet/mptcp/protocol.c net/mptcp/protocol.h+99 -181 reply
12/13mptcp: call tcp_cleanup_rbuf on subflowsinclude/net/tcp.h net/ipv4/tcp.c net/mptcp/protocol.c +1 more+11 -10 replies
13/13mptcp: simult flow self-teststools/testing/selftests/net/mptcp/Makefile tools/testing/selftests/net/mptcp/simult_flows.sh+295 -11 reply

Reviews trailers per patch

All 13 patches have a Reviewed-by or Acked-by.

PatchMat Martineau
1/13R-b
2/13R-b
3/13R-b
4/13R-b
5/13R-b
6/13R-b
7/13R-b
8/13R-b
9/13R-b
10/13R-b
11/13R-b
12/13R-b
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next v2 00/13] mptcp: introduce support for real multipath xmit

This series enable MPTCP socket to transmit data on multiple subflows concurrently in a load balancing scenario.

First the receive code path is refactored to better deal with out-of-order data (patches 1-7). An RB-tree is introduced to queue MPTCP-level out-of-order data, closely resembling the TCP level OoO handling.

When data is sent on multiple subflows, the peer can easily see OoO - "future" data at the MPTCP level, especially if speeds, delay, or jitter are not symmetric.

The other major change regards the netlink PM, which is extended to allow creating non backup subflows in patches 9-11.

There are a few smaller additions, like the introduction of OoO related mibs, send buffer autotuning and better ack handling.

Finally a bunch of new self-tests is introduced. The new feature is tested ensuring that the B/W used by an MPTCP socket using multiple subflows matches the link aggregated B/W - we use low B/W virtual links, to ensure the tests are not CPU bounded.

v1 -> v2:
- fix 32 bit build breakage
- fix a bunch of checkpatch issues

Paolo Abeni (13):
mptcp: rethink 'is writable' conditional
mptcp: set data_ready status bit in subflow_check_data_avail()
mptcp: trigger msk processing even for OoO data
mptcp: basic sndbuf autotuning
mptcp: introduce and use mptcp_try_coalesce()
mptcp: move ooo skbs into msk out of order queue.
mptcp: cleanup mptcp_subflow_discard_data()
mptcp: add OoO related mibs
mptcp: move address attribute into mptcp_addr_info
mptcp: allow creating non-backup subflows
mptcp: allow picking different xmit subflows
mptcp: call tcp_cleanup_rbuf on subflows
mptcp: simult flow self-tests

 include/net/tcp.h                             |   2 +
 net/ipv4/tcp.c                                |   2 +-
 net/mptcp/mib.c                               |   5 +
 net/mptcp/mib.h                               |   5 +
 net/mptcp/pm_netlink.c                        |  39 +-
 net/mptcp/protocol.c                          | 511 ++++++++++++++----
 net/mptcp/protocol.h                          |  21 +-
 net/mptcp/subflow.c                           |  99 ++--
 tools/testing/selftests/net/mptcp/Makefile    |   3 +-
 .../selftests/net/mptcp/simult_flows.sh       | 293 ++++++++++
 10 files changed, 798 insertions(+), 182 deletions(-)
 create mode 100755 tools/testing/selftests/net/mptcp/simult_flows.sh
Signature · 1 line
2.26.2