Skip to content

drm/tilcdc: Couple of minor feature improvements

Jyri Sarha dri-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyIn review
  2. v22 patches 1 replySuperseded
  3. v12 patches 3 repliesSuperseded

Changes in v3 from the cover letter

- "drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data"
- Add reviewed-by tag
- fix:
-:106: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #106: FILE: drivers/gpu/drm/tilcdc/tilcdc_drv.c:289:
+ if (of_property_read_u32(node, "max-pixelclock",
+ &priv->max_pixelclock))

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2drm/tilcdc: Do not keep vblank interrupts enabled all the timedrivers/gpu/drm/tilcdc/tilcdc_crtc.c+33 -30 replies
2/2drm/tilcdc: Remove tilcdc_crtc_max_width(), use private datadrivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_drv.h+26 -351 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchTomi ValkeinenLaurent Pinchart
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] drm/tilcdc: Couple of minor feature improvements

Since v2:
- "drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data"
- Add reviewed-by tag
- fix:
-:106: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #106: FILE: drivers/gpu/drm/tilcdc/tilcdc_drv.c:289:
+ if (of_property_read_u32(node, "max-pixelclock",
+ &priv->max_pixelclock))

Since first version.
- "drm/tilcdc: Do not keep vblank interrupts enabled all the time"
- Add reviewed-by tags
- "drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data"
- Put TILCDC_DEFAULT_MAX_WIDTH_V1 before *_V2 and

The vblank interrupts have been always on when the display is on for a very long time, so I decided that it is about time to fix it. Then the following patch is just a cleanup.

BR,
Jyri

Jyri Sarha (2):
drm/tilcdc: Do not keep vblank interrupts enabled all the time drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data

 drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 52 ++++++++++++++++++----------
 drivers/gpu/drm/tilcdc/tilcdc_drv.c  | 38 +++++++++++---------
 drivers/gpu/drm/tilcdc/tilcdc_drv.h  |  7 ++--
 3 files changed, 59 insertions(+), 38 deletions(-)
Signature · 6 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel