Skip to content

SEV-ES hypervisor support

Tom Lendacky kvm lkml 6 versions – Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest posting 2/234 patches 26 repliesApplied
  2. v5 posting 1/27 of 34 patches 1 replySuperseded
  3. v434 patches 3 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v334 patches0 repliesSuperseded
v2 RFC33 patches0 repliesSuperseded
v1 RFC35 patches51 repliesSuperseded

Changes in v5 from the cover letter

- Updated the tracking support for CR0/CR4

Patches in v5 posting 2/2 Applied

#Subject and filesSizeRepliesApplied
1/34x86/cpu: Add VM page flush MSR availablility as a CPUID featurearch/x86/include/asm/cpufeatures.h arch/x86/include/asm/msr-index.h arch/x86/kernel/cpu/scattered.c+3 -00 replies
2/34KVM: SVM: Remove the call to sev_platform_status() during setuparch/x86/kvm/svm/sev.c+1 -212 replies
3/34KVM: SVM: Add support for SEV-ES capability in KVMarch/x86/kvm/Kconfig arch/x86/kvm/svm/sev.c arch/x86/kvm/svm/svm.c +1 more+66 -210 replies
4/34KVM: SVM: Add GHCB accessor functions for retrieving fieldsarch/x86/include/asm/svm.h arch/x86/kernel/cpu/vmware.c+16 -60 replies
5/34KVM: SVM: Add support for the SEV-ES VMSAarch/x86/include/asm/kvm_host.h arch/x86/kvm/svm/sev.c arch/x86/kvm/svm/svm.c +1 more+97 -20 replies
6/34KVM: x86: Mark GPRs dirty when writtenarch/x86/kvm/kvm_cache_regs.h+26 -250 replies
7/34KVM: SVM: Add required changes to support intercepts under SEV-ESarch/x86/include/asm/svm.h arch/x86/kvm/svm/svm.c arch/x86/kvm/x86.c+107 -132 replies
8/34KVM: SVM: Prevent debugging under SEV-ESarch/x86/kvm/svm/svm.c arch/x86/kvm/svm/svm.h arch/x86/kvm/x86.c+57 -363 replies
9/34KVM: SVM: Do not allow instruction emulation under SEV-ESarch/x86/kvm/svm/svm.c+6 -00 replies
10/34KVM: SVM: Cannot re-initialize the VMCB after shutdown with SEV-ESarch/x86/kvm/svm/svm.c+7 -00 replies
11/34KVM: SVM: Prepare for SEV-ES exit handling in the sev.c filearch/x86/kvm/svm/svm.c+38 -260 replies
12/34KVM: SVM: Add initial support for a VMGEXIT VMEXITarch/x86/include/asm/svm.h arch/x86/include/uapi/asm/svm.h arch/x86/kvm/svm/sev.c +2 more+294 -34 replies
13/34KVM: SVM: Create trace events for VMGEXIT processingarch/x86/kvm/svm/sev.c arch/x86/kvm/trace.h arch/x86/kvm/x86.c+61 -00 replies
14/34KVM: SVM: Add support for SEV-ES GHCB MSR protocol function 0x002arch/x86/kvm/svm/sev.c arch/x86/kvm/svm/svm.h+42 -10 replies
15/34KVM: SVM: Add support for SEV-ES GHCB MSR protocol function 0x004arch/x86/kvm/svm/sev.c arch/x86/kvm/svm/svm.h+63 -20 replies
16/34KVM: SVM: Add support for SEV-ES GHCB MSR protocol function 0x100arch/x86/kvm/svm/sev.c arch/x86/kvm/svm/svm.h+19 -02 replies
17/34KVM: SVM: Create trace events for VMGEXIT MSR protocol processingarch/x86/kvm/svm/sev.c arch/x86/kvm/trace.h arch/x86/kvm/x86.c+52 -00 replies
18/34KVM: SVM: Support MMIO for an SEV-ES guestarch/x86/kvm/svm/sev.c arch/x86/kvm/svm/svm.h arch/x86/kvm/x86.c +1 more+258 -00 replies
19/34KVM: SVM: Support string IO operations for an SEV-ES guestarch/x86/include/asm/kvm_host.h arch/x86/kvm/svm/sev.c arch/x86/kvm/svm/svm.c +3 more+83 -50 replies
20/34KVM: SVM: Add support for EFER write traps for an SEV-ES guestarch/x86/include/uapi/asm/svm.h arch/x86/kvm/svm/svm.c+22 -00 replies
21/34KVM: SVM: Add support for CR0 write traps for an SEV-ES guestarch/x86/include/asm/kvm_host.h arch/x86/include/uapi/asm/svm.h arch/x86/kvm/svm/svm.c +1 more+64 -130 replies
22/34KVM: SVM: Add support for CR4 write traps for an SEV-ES guestarch/x86/include/asm/kvm_host.h arch/x86/include/uapi/asm/svm.h arch/x86/kvm/svm/svm.c +1 more+21 -40 replies
23/34KVM: SVM: Add support for CR8 write traps for an SEV-ES guestarch/x86/include/uapi/asm/svm.h arch/x86/kvm/svm/svm.c+7 -10 replies
24/34KVM: x86: Update __get_sregs() / __set_sregs() to support SEV-ESarch/x86/kvm/x86.c+18 -90 replies
25/34KVM: SVM: Do not report support for SMM for an SEV-ES guestarch/x86/include/asm/kvm_host.h arch/x86/kvm/svm/svm.c arch/x86/kvm/vmx/vmx.c +1 more+18 -50 replies
26/34KVM: SVM: Guest FPU state save/restore not needed for SEV-ES guestarch/x86/include/asm/kvm_host.h arch/x86/kvm/svm/svm.c arch/x86/kvm/x86.c+56 -100 replies
27/34KVM: SVM: Add support for booting APs for an SEV-ES guestarch/x86/include/asm/kvm_host.h arch/x86/kvm/svm/sev.c arch/x86/kvm/svm/svm.c +2 more+71 -06 replies
27/34KVM: SVM: Add support for booting APs in an SEV-ES guestarch/x86/include/asm/kvm_host.h arch/x86/kvm/lapic.c arch/x86/kvm/svm/sev.c +5 more+63 -62 replies
28/34KVM: SVM: Add NMI support for an SEV-ES guestarch/x86/kvm/svm/sev.c arch/x86/kvm/svm/svm.c+17 -70 replies
29/34KVM: SVM: Set the encryption mask for the SVM host save areaarch/x86/kvm/svm/sev.c arch/x86/kvm/svm/svm.c arch/x86/kvm/svm/svm.h+4 -20 replies
30/34KVM: SVM: Update ASID allocation to support SEV-ES guestsarch/x86/kvm/svm/sev.c+14 -110 replies
31/34KVM: SVM: Provide support for SEV-ES vCPU creation/loadingarch/x86/include/asm/svm.h arch/x86/kvm/svm/sev.c arch/x86/kvm/svm/svm.c +1 more+92 -50 replies
32/34KVM: SVM: Provide support for SEV-ES vCPU loadingarch/x86/include/asm/svm.h arch/x86/kvm/svm/sev.c arch/x86/kvm/svm/svm.c +3 more+103 -230 replies
33/34KVM: SVM: Provide an updated VMRUN invocation for SEV-ES guestsarch/x86/kvm/svm/svm.c arch/x86/kvm/svm/svm.h arch/x86/kvm/svm/vmenter.S +1 more+77 -90 replies
34/34KVM: SVM: Provide support to launch and run an SEV-ES guestarch/x86/kvm/svm/sev.c+104 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 00/34] SEV-ES hypervisor support

From: Tom Lendacky <[email protected]>

This patch series provides support for running SEV-ES guests under KVM.

Secure Encrypted Virtualization - Encrypted State (SEV-ES) expands on the SEV support to protect the guest register state from the hypervisor. See "AMD64 Architecture Programmer's Manual Volume 2: System Programming", section "15.35 Encrypted State (SEV-ES)" [1].

In order to allow a hypervisor to perform functions on behalf of a guest, there is architectural support for notifying a guest's operating system when certain types of VMEXITs are about to occur. This allows the guest to selectively share information with the hypervisor to satisfy the requested function. The notification is performed using a new exception, the VMM Communication exception (#VC). The information is shared through the Guest-Hypervisor Communication Block (GHCB) using the VMGEXIT instruction. The GHCB format and the protocol for using it is documented in "SEV-ES Guest-Hypervisor Communication Block Standardization" [2].

Under SEV-ES, a vCPU save area (VMSA) must be encrypted. SVM is updated to build the initial VMSA and then encrypt it before running the guest. Once encrypted, it must not be modified by the hypervisor. Modification of the VMSA will result in the VMRUN instruction failing with a SHUTDOWN exit code. KVM must support the VMGEXIT exit code in order to perform the necessary functions required of the guest. The GHCB is used to exchange the information needed by both the hypervisor and the guest.

Register data from the GHCB is copied into the KVM register variables and accessed as usual during handling of the exit. Upon return to the guest, updated registers are copied back to the GHCB for the guest to act upon.

There are changes to some of the intercepts that are needed under SEV-ES. For example, CR0 writes cannot be intercepted, so the code needs to ensure that the intercept is not enabled during execution or that the hypervisor does not try to read the register as part of exit processing. Another example is shutdown processing, where the vCPU cannot be directly reset.

Support is added to handle VMGEXIT events and implement the GHCB protocol. This includes supporting standard exit events, like a CPUID instruction intercept, to new support, for things like AP processor booting. Much of the existing SVM intercept support can be re-used by setting the exit code information from the VMGEXIT and calling the appropriate intercept handlers.

Finally, to launch and run an SEV-ES guest requires changes to the vCPU initialization, loading and execution.

[1] https://www.amd.com/system/files/TechDocs/24593.pdf
[2] https://developer.amd.com/wp-content/resources/56421.pdf

---

These patches are based on the KVM queue branch:
https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue

dc924b062488 ("KVM: SVM: check CR4 changes against vcpu->arch")

A version of the tree can also be found at:
https://github.com/AMDESE/linux/tree/sev-es-v5
This tree has one addition patch that is not yet part of the queue tree that is required to run any SEV guest:
[PATCH] KVM: x86: adjust SEV for commit 7e8e6eed75e
https://lore.kernel.org/kvm/[email protected]/

Changes from v4:
- Updated the tracking support for CR0/CR4

Changes from v3:
- Some krobot fixes.
- Some checkpatch cleanups.

Changes from v2:
- Update the freeing of the VMSA page to account for the encrypted memory cache coherency feature as well as the VM page flush feature.
- Update the GHCB dump function with a bit more detail.
- Don't check for RAX being present as part of a string IO operation.
- Include RSI when syncing from GHCB to support KVM hypercall arguments.
- Add GHCB usage field validation check.

Changes from v1:
- Removed the VMSA indirection support:
- On LAUNCH_UPDATE_VMSA, sync traditional VMSA over to the new SEV-ES VMSA area to be encrypted.
- On VMGEXIT VMEXIT, directly copy valid registers into vCPU arch register array from GHCB. On VMRUN (following a VMGEXIT), directly copy dirty vCPU arch registers to GHCB.
- Removed reg_read_override()/reg_write_override() KVM ops.
- Added VMGEXIT exit-reason validation.
- Changed kvm_vcpu_arch variable vmsa_encrypted to guest_state_protected
- Updated the tracking support for EFER/CR0/CR4/CR8 to minimize changes to the x86.c code
- Updated __set_sregs to not set any register values (previously supported setting the tracked values of EFER/CR0/CR4/CR8)
- Added support for reporting SMM capability at the VM-level. This allows an SEV-ES guest to indicate SMM is not supported
- Updated FPU support to check for a guest FPU save area before using it. Updated SVM to free guest FPU for an SEV-ES guest during KVM create_vcpu op.
- Removed changes to the kvm_skip_emulated_instruction()
- Added VMSA validity checks before invoking LAUNCH_UPDATE_VMSA
- Minor code restructuring in areas for better readability

Cc Paolo Bonzini <[email protected]>
Cc Jim Mattson <[email protected]>
Cc Joerg Roedel <[email protected]>
Cc Sean Christopherson <[email protected]>
Cc Vitaly Kuznetsov <[email protected]>
Cc Wanpeng Li <[email protected]>
Cc Borislav Petkov <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Brijesh Singh <[email protected]>

Tom Lendacky (34):
x86/cpu: Add VM page flush MSR availablility as a CPUID feature
KVM: SVM: Remove the call to sev_platform_status() during setup
KVM: SVM: Add support for SEV-ES capability in KVM
KVM: SVM: Add GHCB accessor functions for retrieving fields
KVM: SVM: Add support for the SEV-ES VMSA
KVM: x86: Mark GPRs dirty when written
KVM: SVM: Add required changes to support intercepts under SEV-ES
KVM: SVM: Prevent debugging under SEV-ES
KVM: SVM: Do not allow instruction emulation under SEV-ES
KVM: SVM: Cannot re-initialize the VMCB after shutdown with SEV-ES
KVM: SVM: Prepare for SEV-ES exit handling in the sev.c file
KVM: SVM: Add initial support for a VMGEXIT VMEXIT
KVM: SVM: Create trace events for VMGEXIT processing
KVM: SVM: Add support for SEV-ES GHCB MSR protocol function 0x002
KVM: SVM: Add support for SEV-ES GHCB MSR protocol function 0x004
KVM: SVM: Add support for SEV-ES GHCB MSR protocol function 0x100
KVM: SVM: Create trace events for VMGEXIT MSR protocol processing
KVM: SVM: Support MMIO for an SEV-ES guest
KVM: SVM: Support string IO operations for an SEV-ES guest
KVM: SVM: Add support for EFER write traps for an SEV-ES guest
KVM: SVM: Add support for CR0 write traps for an SEV-ES guest
KVM: SVM: Add support for CR4 write traps for an SEV-ES guest
KVM: SVM: Add support for CR8 write traps for an SEV-ES guest
KVM: x86: Update __get_sregs() / __set_sregs() to support SEV-ES
KVM: SVM: Do not report support for SMM for an SEV-ES guest
KVM: SVM: Guest FPU state save/restore not needed for SEV-ES guest
KVM: SVM: Add support for booting APs for an SEV-ES guest
KVM: SVM: Add NMI support for an SEV-ES guest
KVM: SVM: Set the encryption mask for the SVM host save area
KVM: SVM: Update ASID allocation to support SEV-ES guests
KVM: SVM: Provide support for SEV-ES vCPU creation/loading
KVM: SVM: Provide support for SEV-ES vCPU loading
KVM: SVM: Provide an updated VMRUN invocation for SEV-ES guests
KVM: SVM: Provide support to launch and run an SEV-ES guest

 arch/x86/include/asm/cpufeatures.h |   1 +
 arch/x86/include/asm/kvm_host.h    |  12 +-
 arch/x86/include/asm/msr-index.h   |   1 +
 arch/x86/include/asm/svm.h         |  40 +-
 arch/x86/include/uapi/asm/svm.h    |  28 +
 arch/x86/kernel/cpu/scattered.c    |   1 +
 arch/x86/kernel/cpu/vmware.c       |  12 +-
 arch/x86/kvm/Kconfig               |   3 +-
 arch/x86/kvm/kvm_cache_regs.h      |  51 +-
 arch/x86/kvm/svm/sev.c             | 933 +++++++++++++++++++++++++++--
 arch/x86/kvm/svm/svm.c             | 446 +++++++++++---
 arch/x86/kvm/svm/svm.h             | 166 ++++-
 arch/x86/kvm/svm/vmenter.S         |  50 ++
 arch/x86/kvm/trace.h               |  97 +++
 arch/x86/kvm/vmx/vmx.c             |   6 +-
 arch/x86/kvm/x86.c                 | 344 +++++++++--
 arch/x86/kvm/x86.h                 |   9 +
 17 files changed, 1962 insertions(+), 238 deletions(-)

base-commit: dc924b062488a0376aae41d3e0a27dc99f852a5e

Signature · 1 line
2.28.0