mptcp: RM_ADDR/ADD_ADDR enhancements
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest16 patches 14 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/16 | mptcp: rename addr_signal and the related functionsnet/ net/ net/ | +18 | 1 reply | |
| 2/16 | mptcp: add the outgoing RM_ADDR supportnet/ net/ net/ | +63 | 1 reply | |
| 3/16 | mptcp: add the incoming RM_ADDR supportnet/ net/ net/ +2 more | +66 | 1 reply | |
| 4/16 | mptcp: send out ADD_ADDR with echo flagnet/ net/ net/ +1 more | +32 | 0 replies | |
| 5/16 | mptcp: add ADD_ADDR related mibsnet/ net/ net/ | +10 | 0 replies | |
| 6/16 | selftests: mptcp: add ADD_ADDR mibs check functiontools/ | +44 | 0 replies | |
| 7/16 | mptcp: add accept_subflow re-checknet/ | +6 | 0 replies | |
| 8/16 | mptcp: remove addr and subflow in PM netlinknet/ net/ net/ +2 more | +130 | 1 reply | |
| 9/16 | mptcp: implement mptcp_pm_remove_subflownet/ net/ net/ | +42 | 2 replies | |
| 10/16 | mptcp: add RM_ADDR related mibsnet/ net/ net/ | +9 | 1 reply | |
| 11/16 | mptcp: add mptcp_destroy_common helpernet/ net/ net/ | +10 | 1 reply | |
| 12/16 | selftests: mptcp: add remove cfg in mptcp_connecttools/ | +15 | 1 reply | |
| 13/16 | selftests: mptcp: add remove addr and subflow test casestools/ | +142 | 1 reply | |
| 14/16 | mptcp: add struct mptcp_pm_add_entrynet/ | +12 | 1 reply | |
| 15/16 | mptcp: add sk_stop_timer_sync helperinclude/ net/ | +9 | 1 reply | |
| 16/16 | mptcp: retransmit ADD_ADDR when timeoutnet/ net/ net/ | +96 | 1 reply |
Reviews trailers per patch
All 16 patches have a Reviewed-by or Acked-by.
| Patch | Mat Martineau | Paolo Abeni |
|---|---|---|
| 1/16 | R-b | |
| 2/16 | R-b | |
| 3/16 | R-b | |
| 4/16 | R-b | |
| 5/16 | R-b | |
| 6/16 | R-b | |
| 7/16 | R-b | |
| 8/16 | R-b | A-b |
| 9/16 | R-b | |
| 10/16 | R-b | A-b |
| 11/16 | R-b | |
| 12/16 | R-b | A-b |
| 13/16 | R-b | A-b |
| 14/16 | R-b | A-b |
| 15/16 | R-b | A-b |
| 16/16 | R-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [MPTCP][PATCH net-next 00/16] mptcp: RM_ADDR/ADD_ADDR enhancements
This series include two enhancements for the MPTCP path management, namely RM_ADDR support and ADD_ADDR echo support, as specified by RFC sections 3.4.1 and 3.4.2.
1 RM_ADDR support include 9 patches (1-3 and 8-13):
Patch 1 is the helper for patch 2, these two patches add the RM_ADDR outgoing functions, which are derived from ADD_ADDR's corresponding functions.
Patch 3 adds the RM_ADDR incoming logic, when RM_ADDR suboption is received, close the subflow matching the rm_id, and update PM counter.
Patch 8 is the main remove routine. When the PM netlink removes an address, we traverse all the existing msk sockets to find the relevant sockets. Then trigger the RM_ADDR signal and remove the subflow which using this local address, this subflow removing functions has been implemented in patch 9.
Finally, patches 10-13 are the self-tests for RM_ADDR.
2 ADD_ADDR echo support include 7 patches (4-7 and 14-16).
Patch 4 adds the ADD_ADDR echo logic, when the ADD_ADDR suboption has been received, send out the same ADD_ADDR suboption with echo-flag, and no HMAC included.
Patches 5 and 6 are the self-tests for ADD_ADDR echo. Patch 7 is a little cleaning up.
Patch 14 and 15 are the helpers for patch 16. These three patches add the ADD_ADDR retransmition when no ADD_ADDR echo is received.
Geliang Tang (16):
mptcp: rename addr_signal and the related functions
mptcp: add the outgoing RM_ADDR support
mptcp: add the incoming RM_ADDR support
mptcp: send out ADD_ADDR with echo flag
mptcp: add ADD_ADDR related mibs
selftests: mptcp: add ADD_ADDR mibs check function
mptcp: add accept_subflow re-check
mptcp: remove addr and subflow in PM netlink
mptcp: implement mptcp_pm_remove_subflow
mptcp: add RM_ADDR related mibs
mptcp: add mptcp_destroy_common helper
selftests: mptcp: add remove cfg in mptcp_connect
selftests: mptcp: add remove addr and subflow test cases
mptcp: add struct mptcp_pm_add_entry
mptcp: add sk_stop_timer_sync helper
mptcp: retransmit ADD_ADDR when timeout
include/net/sock.h | 2 + net/core/sock.c | 7 + net/mptcp/mib.c | 4 + net/mptcp/mib.h | 4 + net/mptcp/options.c | 81 +++-- net/mptcp/pm.c | 91 ++++-- net/mptcp/pm_netlink.c | 276 +++++++++++++++++- net/mptcp/protocol.c | 30 +- net/mptcp/protocol.h | 39 ++- net/mptcp/subflow.c | 3 +- .../selftests/net/mptcp/mptcp_connect.c | 18 +- .../testing/selftests/net/mptcp/mptcp_join.sh | 189 +++++++++++- 12 files changed, 674 insertions(+), 70 deletions(-)
Signature · 1 line
2.17.1