Skip to content

RFC mptcp: support for queuing data at mptcp-level

Paolo Abeni mptcp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest8 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8tcp: factor out __tcp_close() helperinclude/net/tcp.h net/ipv4/tcp.c+8 -20 replies
2/8mptcp: introduce mptcp_schedule_worknet/mptcp/pm.c net/mptcp/protocol.c net/mptcp/protocol.h+21 -170 replies
3/8mptcp: reduce the arguments of mptcp_sendmsg_fragnet/mptcp/protocol.c+29 -240 replies
4/8mptcp: add accounting for pending datanet/mptcp/protocol.c net/mptcp/protocol.h+36 -30 replies
5/8mptcp: introduce MPTCP snd_nxtnet/mptcp/options.c net/mptcp/protocol.c net/mptcp/protocol.h+16 -120 replies
6/8mptcp: refactor shutdown and closenet/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/subflow.c+203 -865 replies
7/8mptcp: move page frag allocation in mptcp_sendmsg()net/mptcp/protocol.c+182 -2181 reply
8/8mptcp: try to push pending data on snd una updatesnet/mptcp/protocol.c+3 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [MPTCP] [RFC PATCH 0/8] mptcp: support for queuing data at mptcp-level

This is necessary to cope correctly with large sendbuffer (larger then snd wnd) while respecting the MPTCP level snd window.

A major rework of both xmit and shudown path is required to support this feature (patches 6 and 7). To try to keep the related patches as small as possible, a bunch of new helpers is created by patches 1-5.
Note that patch 3 can stand for it's own merit and possibly be upstreamed soon.

Finally patch 8 uses the MPTCP equivalent of tcp_push_pending_frames(), to spool queued data ad MPTCP level, as soon as the windows allow that.

This is still more than a bit rough, and not all self-tests currently pass in my local testbed, but the major issues should have been addressed.

Specifically the race described in:

https://lists.01.org/hyperkitty/list/mptcp(a)lists.01.org/message/JC7GTZHEKI6A3WHQKAWF3SYUSBEU5DYM/

is addressed by patch 6.

As usual any comments more than welcome!

Note: some patches include [partial] changelog, because this already went through some private iterations.

Paolo Abeni (8):
tcp: factor out __tcp_close() helper
mptcp: introduce mptcp_schedule_work
mptcp: reduce the arguments of mptcp_sendmsg_frag
mptcp: add accounting for pending data
mptcp: introduce MPTCP snd_nxt
mptcp: refactor shutdown and close
mptcp: move page frag allocation in mptcp_sendmsg()
mptcp: try to push pending data on snd una updates

 include/net/tcp.h    |   1 +
 net/ipv4/tcp.c       |   9 +-
 net/mptcp/options.c  |   4 +-
 net/mptcp/pm.c       |   4 +-
 net/mptcp/protocol.c | 729 ++++++++++++++++++++++++-------------------
 net/mptcp/protocol.h |  60 +++-
 net/mptcp/subflow.c  |  21 +-
 7 files changed, 482 insertions(+), 346 deletions(-)
Signature · 1 line
2.26.2