Skip to content

9pfs: add tests using local fs driver

Christian Schoenebeck qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest12 patches 15 repliesIn review
  2. v311 patches 10 repliesSuperseded
  3. v211 patches 10 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v112 patches13 repliesSuperseded

Changes in v4 from the cover letter

* Added qos_printf() and qos_printf_literal() (NEW patch 3).

* Use qos_printf() and qos_printf_literal() instead of printf() for not breaking TAP output (patch 4, 6, 7).

* Added private function regex_replace() to simplify and deduplicate code

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12libqos/qgraph: add qemu_name to QOSGraphNodetests/qtest/libqos/qgraph.c tests/qtest/libqos/qgraph_internal.h+2 -03 replies
2/12libqos/qgraph: add qos_node_create_driver_named()tests/qtest/libqos/qgraph.c tests/qtest/libqos/qgraph.h+66 -30 replies
3/12libqos/qgraph_internal: add qos_printf() and qos_printf_literal()tests/qtest/libqos/qgraph_internal.h+11 -00 replies
4/12libqos/qgraph: add qos_dump_graph()tests/qtest/libqos/qgraph.c tests/qtest/libqos/qgraph.h+76 -05 replies
5/12tests/qtest/qos-test: dump qos graph if verbosetests/qtest/qos-test.c+3 -02 replies
6/12tests/qtest/qos-test: dump environment variables if verbosetests/qtest/qos-test.c+8 -12 replies
7/12tests/qtest/qos-test: dump QEMU command if verbosetests/qtest/qos-test.c+3 -00 replies
8/12tests/9pfs: change qtest name prefix to synthtests/qtest/virtio-9p-test.c+14 -143 replies
9/12tests/9pfs: introduce local teststests/qtest/libqos/virtio-9p.c tests/qtest/libqos/virtio-9p.h tests/qtest/virtio-9p-test.c+116 -140 replies
10/12tests/9pfs: wipe local 9pfs test directorytests/qtest/libqos/virtio-9p.c+13 -00 replies
11/12tests/9pfs: add virtio_9p_test_path()tests/qtest/libqos/virtio-9p.c tests/qtest/libqos/virtio-9p.h+11 -00 replies
12/12tests/9pfs: add local Tmkdir testtests/qtest/virtio-9p-test.c+139 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 00/12] 9pfs: add tests using local fs driver

The currently existing 9pfs test cases are all solely using the 9pfs 'synth' fileystem driver, which is a very simple and purely simulated (in RAM only) filesystem. There are issues though where the 'synth' fs driver is not sufficient. For example the following two bugs need test cases running the 9pfs 'local' fs driver:

https://bugs.launchpad.net/qemu/+bug/1336794
https://bugs.launchpad.net/qemu/+bug/1877384

This patch set for that reason introduces 9pfs test cases using the 9pfs 'local' filesystem driver along to the already existing tests on 'synth'. It consists of 3 parts:

1. libqos patches 1 and 2 remove a limitation of the qtest/libqos subsystem:
support for more than one device using the same (official) QEMU device name.

2. Patches 3 to 7 enhance debugging issues with the qtest framework.

3. Patches 8 to 12 actually introduce 9pfs 'local' test cases using the qtest framework. These 'local' tests are adding a test directory 'qtest-9p-local' inside the current working directory (using get_current_dir()), which is typically the build directory, before running the tests. That test directory is automatically recreated next time the test suite is run again, to ensure the 9pfs 'local' tests always run consistently on a clean test directory. The test directory is used by the 'local' driver as root of its export path. So it will add/read/write/delete real files and directories inside that test directory.

v3->v4:

* Added qos_printf() and qos_printf_literal() (NEW patch 3).

* Use qos_printf() and qos_printf_literal() instead of printf() for not breaking TAP output (patch 4, 6, 7).

* Added private function regex_replace() to simplify and deduplicate code

    (patch 9).

* RegEx pattern hardening in virtio_9p_assign_local_driver() to avoid potential issues with future changes (patch 9).

* Updated commit log comments.

v2->v3:

* concat_path() is now just a wrapper for g_build_filename() (patch 8).

* Dropped function strpr(), using g_strdup_printf() instead (patch 8, 9).

* Fixed incorrect size for array allocation in split() function

    (patch 11).

v1->v2:

* The libqos debugging features are now turned on by command line argument '--verbose' instead of using environment variables (patches 4, 5, 6).

* The new 9pfs 'local' tests no longer depend on patches 1 and 2 by no longer using a libqos multi-device approach, but rather modifying the final QEMU command line for each test instead; see discussion of v1 for reason (patches 7 to 11).

* Use GCC_FMT_ATTR on helper function strpr() (patch 8).

* Updated commit log comments.

Christian Schoenebeck (12):
libqos/qgraph: add qemu_name to QOSGraphNode libqos/qgraph: add qos_node_create_driver_named() libqos/qgraph_internal: add qos_printf() and qos_printf_literal() libqos/qgraph: add qos_dump_graph() tests/qtest/qos-test: dump qos graph if verbose tests/qtest/qos-test: dump environment variables if verbose tests/qtest/qos-test: dump QEMU command if verbose tests/9pfs: change qtest name prefix to synth tests/9pfs: introduce local tests
tests/9pfs: wipe local 9pfs test directory
tests/9pfs: add virtio_9p_test_path()
tests/9pfs: add local Tmkdir test

 tests/qtest/libqos/qgraph.c          | 110 ++++++++++++++-
 tests/qtest/libqos/qgraph.h          |  36 +++++
 tests/qtest/libqos/qgraph_internal.h |  12 ++
 tests/qtest/libqos/virtio-9p.c       | 100 ++++++++++++++
 tests/qtest/libqos/virtio-9p.h       |  10 ++
 tests/qtest/qos-test.c               |  15 +-
 tests/qtest/virtio-9p-test.c         | 197 ++++++++++++++++++++++++---
 7 files changed, 455 insertions(+), 25 deletions(-)
Signature · 1 line
2.20.1