Skip to content

mptcp: support for queuing data at mptcp-level

Paolo Abeni mptcp 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest13 patches 9 repliesIn review
  2. v213 patches 1 replySuperseded
  3. v19 patches 3 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13mptcp: more DATA FIN fixesnet/mptcp/options.c net/mptcp/subflow.c+6 -61 reply
2/13mptcp: don't skip needed acknet/mptcp/protocol.c+4 -20 replies
3/13tcp: factor out __tcp_close() helperinclude/net/tcp.h net/ipv4/tcp.c+8 -20 replies
4/13mptcp: introduce mptcp_schedule_worknet/mptcp/pm.c net/mptcp/protocol.c net/mptcp/protocol.h+21 -160 replies
5/13mptcp: reduce the arguments of mptcp_sendmsg_fragnet/mptcp/protocol.c+29 -240 replies
6/13mptcp: add accounting for pending datanet/mptcp/protocol.c net/mptcp/protocol.h+36 -30 replies
7/13mptcp: introduce MPTCP snd_nxtnet/mptcp/options.c net/mptcp/protocol.c net/mptcp/protocol.h+16 -120 replies
8/13mptcp: refactor shutdown and closenet/mptcp/options.c net/mptcp/protocol.c net/mptcp/protocol.h +1 more+216 -860 replies
9/13mptcp: move page frag allocation in mptcp_sendmsg()net/mptcp/protocol.c+188 -2180 replies
10/13mptcp: try to push pending data on snd una updatesnet/mptcp/protocol.c+3 -00 replies
11/13mptcp: rework poll+nospace handlingnet/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/subflow.c+54 -510 replies
12/13mptcp: keep track of advertised windows right edgenet/mptcp/options.c net/mptcp/protocol.c net/mptcp/protocol.h+67 -54 replies
13/13mptcp: send explicit ack on delayed ack_seq incrnet/mptcp/protocol.c+22 -140 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [MPTCP] [PATCH v3 00/13] mptcp: support for queuing data at mptcp-level

This is necessary to cope correctly with large sendbuffer (larger then snd wnd) while respecting the MPTCP level snd window.

A major rework of both xmit and shudown path is required to support this feature (patches 8 and 9). To try to keep the related patches as small as possible, a bunch of new helpers is created by patches 3-7.
Note that patch 5 can stand for it's own merit and possibly be upstreamed soon.

Finally patch 10 uses the MPTCP equivalent of tcp_push_pending_frames(), to spool queued data ad MPTCP level, as soon as the windows allow that.

Patches 1 and 2 are bugfixes for the current upstream tree will target -net/-net-next soon.

Patch 13 is possibly a bit too aggressive, perhaps it could be left staging in export branch for a while.

This iteration fixes all known pending issue present in previous snapshow. Note that we still hit some unexpected out of receive window events, but the issue was already present in the export branch and its fix is unrelated to this work.

Florian Westphal (2):
mptcp: rework poll+nospace handling
mptcp: keep track of advertised windows right edge

Paolo Abeni (11):
mptcp: more DATA FIN fixes
mptcp: don't skip needed ack
tcp: factor out __tcp_close() helper
mptcp: introduce mptcp_schedule_work
mptcp: reduce the arguments of mptcp_sendmsg_frag
mptcp: add accounting for pending data
mptcp: introduce MPTCP snd_nxt
mptcp: refactor shutdown and close
mptcp: move page frag allocation in mptcp_sendmsg()
mptcp: try to push pending data on snd una updates
mptcp: send explicit ack on delayed ack_seq incr

 include/net/tcp.h    |   1 +
 net/ipv4/tcp.c       |   9 +-
 net/mptcp/options.c  |  40 +-
 net/mptcp/pm.c       |   3 +-
 net/mptcp/protocol.c | 909 +++++++++++++++++++++++++------------------
 net/mptcp/protocol.h |  69 +++-
 net/mptcp/subflow.c  |  34 +-
 7 files changed, 648 insertions(+), 417 deletions(-)
Signature · 1 line
2.26.2