Skip to content

fixes for REQ_F_COMP_LOCKED

Pavel Begunkov io-uring 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5io_uring: don't set COMP_LOCKED if won't putfs/io_uring.c+1 -10 replies
2/5io_uring: don't unnecessarily clear F_LINK_TIMEOUTfs/io_uring.c+0 -10 replies
3/5io_uring: don't put a poll req under spinlockfs/io_uring.c+1 -21 reply
4/5io_uring: dig out COMP_LOCK from deep call chainfs/io_uring.c+9 -240 replies
5/5io_uring: fix REQ_F_COMP_LOCKED by killing itfs/io_uring.c+51 -780 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] fixes for REQ_F_COMP_LOCKED

This removes REQ_F_COMP_LOCKED to fix a couple of problems with it.

[5/5] is harsh and some work should be done to ease the aftermath, i.e. io_submit_flush_completions() and maybe fail_links().

Another way around would be to replace the flag with an comp_locked argument in put_req(), free_req() and so on, but IMHO in a long run removing it should be better.

note: there is a new io_req_task_work_add() call in [5/5]. Jens, could you please verify whether passed @twa_signal_ok=true is ok, because I don't really understand the difference.

Pavel Begunkov (5):
io_uring: don't set COMP_LOCKED if won't put
io_uring: don't unnecessarily clear F_LINK_TIMEOUT
io_uring: don't put a poll req under spinlock
io_uring: dig out COMP_LOCK from deep call chain
io_uring: fix REQ_F_COMP_LOCKED by killing it

 fs/io_uring.c | 158 ++++++++++++++++++--------------------------------
 1 file changed, 57 insertions(+), 101 deletions(-)
Signature · 1 line
2.24.0