Skip to content

Some block rsv fixes

Josef Bacik linux-btrfs 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 3 repliesIn review
  2. v12 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- change the logic to max(1, root level), as generally we do not walk down into level 0 for the merge, with the exception for root level == 0.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: print the block rsv type when we fail our reservationfs/btrfs/block-rsv.c+2 -11 reply
2/2btrfs: fix min reserved size calculation in merge_reloc_rootfs/btrfs/relocation.c+3 -11 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchNikolay Borisov
1/2R-b
2/2R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] Some block rsv fixes

v1->v2:
- change the logic to max(1, root level), as generally we do not walk down into level 0 for the merge, with the exception for root level == 0.

--- Original email ---

Hello,

Nikolay has noticed that -o enospc_debug was getting some warnings in btrfs_use_block_rsv() on some tests. I dug into them and one class is easy to fix as it's a straight regression. The other one is going to require some more debugging, so in the meantime here's the two patches I have so far that can be merged. The first is just to make my life easier when debugging these problems, and the second is the actual regression fix. It should probably be tagged for stable as well since the regression was backported to stable. Thanks,

Josef

Josef Bacik (2):
btrfs: print the block rsv type when we fail our reservation
btrfs: fix min reserved size calculation in merge_reloc_root

 fs/btrfs/block-rsv.c  | 3 ++-
 fs/btrfs/relocation.c | 4 +++-
 2 files changed, 5 insertions(+), 2 deletions(-)
Signature · 1 line
2.26.2