Skip to content

ADD_ADDR: ports support

Geliang Tang mptcp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8mptcp: add ADD_ADDR port support for writing optionsinclude/net/mptcp.h net/mptcp/options.c net/mptcp/protocol.h+60 -152 replies
2/8mptcp: add the outgoing ADD_ADDR port supportnet/mptcp/options.c net/mptcp/pm.c net/mptcp/protocol.h+25 -71 reply
3/8mptcp: send out ack for ADD_ADDR with portnet/mptcp/options.c net/mptcp/pm.c net/mptcp/pm_netlink.c+15 -50 replies
4/8mptcp: add port argument for mptcp_pm_announce_addrnet/mptcp/pm.c net/mptcp/pm_netlink.c net/mptcp/protocol.h+11 -60 replies
5/8mptcp: add the incoming ADD_ADDR port supportnet/mptcp/options.c net/mptcp/protocol.h+3 -21 reply
6/8mptcp: add ADD_ADDR port support for netlinknet/mptcp/pm_netlink.c+5 -00 replies
7/8selftests: mptcp: add ADD_ADDR port support for pm_nl_ctltools/testing/selftests/net/mptcp/pm_nl_ctl.c+18 -00 replies
8/8selftests: mptcp: add testcases for ADD_ADDR with porttools/testing/selftests/net/mptcp/mptcp_join.sh+25 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [MPTCP] [MPTCP][PATCH mptcp-next 0/8] ADD_ADDR: ports support

This series is the first version of ADD_ADDR ports support. I have solved the listener problem which I mentioned at the meeting on 15th of October by adding a new listening socket from the userspace (see patch 8). Up to now this patchset works well.

TODO:
I added 2 octets padding in ADD_ADDR port suboption for alignment. (see patch 1). We need to drop this padding.

Geliang Tang (8):
mptcp: add ADD_ADDR port support for writing options
mptcp: add the outgoing ADD_ADDR port support
mptcp: send out ack for ADD_ADDR with port
mptcp: add port argument for mptcp_pm_announce_addr
mptcp: add the incoming ADD_ADDR port support
mptcp: add ADD_ADDR port support for netlink
selftests: mptcp: add ADD_ADDR port support for pm_nl_ctl
selftests: mptcp: add testcases for ADD_ADDR with port

 include/net/mptcp.h                           |  1 +
 net/mptcp/options.c                           | 80 +++++++++++++++----
 net/mptcp/pm.c                                | 14 ++--
 net/mptcp/pm_netlink.c                        | 28 +++++--
 net/mptcp/protocol.h                          | 31 ++++---
 .../testing/selftests/net/mptcp/mptcp_join.sh | 26 +++++-
 tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 18 +++++
 7 files changed, 162 insertions(+), 36 deletions(-)
Signature · 1 line
2.26.2