Skip to content

9pfs: test suite fixes

Christian Schoenebeck qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 7 repliesIn review
  2. v22 patches 2 repliesSuperseded
  3. v12 patches 7 repliesSuperseded

Changes in v3 from the cover letter

- Make the two functions for creating and removing the 9pfs test directory public [NEW patch 1].

- Place the constructor and destructor functions in virtio-9p-test.c, not in virtio-9p.c, because the latter location would cause the constructor to be executed whenever libqos is loaded, which would break other, completely unrelated tests suites that just link to libqos [patch 2].

- Previous patch 2 (coverity fix) is already queued, no changes, hence omitted in this v3.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tests/9pfs: make create/remove test dir publictests/qtest/libqos/virtio-9p.c tests/qtest/libqos/virtio-9p.h+14 -61 reply
2/2tests/9pfs: fix test dir for parallel teststests/qtest/libqos/virtio-9p.c tests/qtest/virtio-9p-test.c+20 -63 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchGreg Kurz
1/2R-b
2/2R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] 9pfs: test suite fixes

Fixes test failures with the 9pfs 'local' tests as discussed with latest 9P PR. See the discussion of that PR v2 (Fri, Oct 30th) for details.

In conjunction with Peter Xu's two migration patches (fixing occasional lockups of migration tests) overall situation appears to be smooth now:
https://lore.kernel.org/qemu-devel/20201030135350.GA588069@xz-x1/

v2->v3:

- Make the two functions for creating and removing the 9pfs test directory public [NEW patch 1].

- Place the constructor and destructor functions in virtio-9p-test.c, not in virtio-9p.c, because the latter location would cause the constructor to be executed whenever libqos is loaded, which would break other, completely unrelated tests suites that just link to libqos [patch 2].

- Previous patch 2 (coverity fix) is already queued, no changes, hence omitted in this v3.

v1->v2:

- Added Greg's tested-by tag [patch 1].

- Log an info-level message if mkdir() failed [patch 2].

- Update commit log message about coverity being the reporter and details of the coverity report [patch 2].

Christian Schoenebeck (2):
tests/9pfs: make create/remove test dir public
tests/9pfs: fix test dir for parallel tests

 tests/qtest/libqos/virtio-9p.c | 20 ++++++++++----------
 tests/qtest/libqos/virtio-9p.h | 10 ++++++++++
 tests/qtest/virtio-9p-test.c   | 12 ++++++++++++
 3 files changed, 32 insertions(+), 10 deletions(-)
Signature · 1 line
2.20.1