Skip to content

Locking cleanups and lockdep fix

Josef Bacik linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8btrfs: cleanup the locking in btrfs_next_old_leaffs/btrfs/ctree.c+4 -101 reply
2/8btrfs: unlock to current level in btrfs_next_old_leaffs/btrfs/ctree.c+17 -151 reply
3/8btrfs: kill path->recursefs/btrfs/ctree.c fs/btrfs/ctree.h+2 -31 reply
4/8btrfs: remove the recursion handling code in locking.cfs/btrfs/locking.c+2 -615 replies
5/8btrfs: remove __btrfs_read_lock_root_nodefs/btrfs/ctree.c fs/btrfs/locking.c fs/btrfs/locking.h+4 -111 reply
6/8btrfs: use btrfs_tree_read_lock in btrfs_search_slotfs/btrfs/ctree.c+1 -21 reply
7/8btrfs: remove the recurse parameter from __btrfs_tree_read_lockfs/btrfs/locking.c fs/btrfs/locking.h+3 -61 reply
8/8btrfs: remove ->recursed from extent_bufferfs/btrfs/extent_io.c fs/btrfs/extent_io.h+0 -21 reply

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchFilipe Manana
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] Locking cleanups and lockdep fix

Hello,

Filipe reported a lockdep splat that he hit on btrfs/187, but honestly could be hit anywhere we do readdir on a sufficiently large fs. Fixing this is fairly straightforward, but enabled me to do a lot of extra cleanups, especially now that my other locking fixes have been merged. The first two patches are to address the lockdep problem. The followup patches are cleaning out the recursive locking support, which we no longer require. I would have separated this work, but btrfs_next_old_leaf was a heavy user of this, so it would be annoying to take separately, hence putting it all together. Thanks,

Josef

Josef Bacik (8):
btrfs: cleanup the locking in btrfs_next_old_leaf
btrfs: unlock to current level in btrfs_next_old_leaf
btrfs: kill path->recurse
btrfs: remove the recursion handling code in locking.c
btrfs: remove __btrfs_read_lock_root_node
btrfs: use btrfs_tree_read_lock in btrfs_search_slot
btrfs: remove the recurse parameter from __btrfs_tree_read_lock
btrfs: remove ->recursed from extent_buffer

 fs/btrfs/ctree.c     | 47 +++++++++++++----------------
 fs/btrfs/ctree.h     |  1 -
 fs/btrfs/extent_io.c |  1 -
 fs/btrfs/extent_io.h |  1 -
 fs/btrfs/locking.c   | 72 +++-----------------------------------------
 fs/btrfs/locking.h   | 11 ++-----
 6 files changed, 28 insertions(+), 105 deletions(-)
Signature · 1 line
2.26.2