Skip to content

dpaa_eth: add XDP support

Camelia Groza netdev 5 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest7 patches 2 repliesApplied
  2. v47 patches 14 repliesSuperseded
  3. v37 patches 8 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v27 patches3 repliesSuperseded
v17 patches6 repliesSuperseded

Changes in v5 from the cover letter

- report errors on XDP setup with extack in 2/7
- checkpath fix in 4/7
- add more details in the commit message in 4/7
- reduce the impact of the A050385 erratum workaround code on non-erratum platforms in 7/7

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/7dpaa_eth: add struct for software backpointersdrivers/net/ethernet/freescale/dpaa/dpaa_eth.c drivers/net/ethernet/freescale/dpaa/dpaa_eth.h+17 -70 replies
2/7dpaa_eth: add basic XDP supportdrivers/net/ethernet/freescale/dpaa/dpaa_eth.c drivers/net/ethernet/freescale/dpaa/dpaa_eth.h+153 -160 replies
3/7dpaa_eth: limit the possible MTU range when XDP is enableddrivers/net/ethernet/freescale/dpaa/dpaa_eth.c+31 -80 replies
4/7dpaa_eth: add XDP_TX supportdrivers/net/ethernet/freescale/dpaa/dpaa_eth.c drivers/net/ethernet/freescale/dpaa/dpaa_eth.h+126 -50 replies
5/7dpaa_eth: add XDP_REDIRECT supportdrivers/net/ethernet/freescale/dpaa/dpaa_eth.c drivers/net/ethernet/freescale/dpaa/dpaa_eth.h+48 -10 replies
6/7dpaa_eth: rename current skb A050385 erratum workarounddrivers/net/ethernet/freescale/dpaa/dpaa_eth.c+2 -20 replies
7/7dpaa_eth: implement the A050385 erratum workaround for XDPdrivers/net/ethernet/freescale/dpaa/dpaa_eth.c+82 -20 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMadalin BucurMaciej Fijalkowski
SeriesR-b
1/7A-b
2/7A-b
3/7A-b R-b
4/7A-b R-b
5/7A-b R-b
6/7A-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH net-next v5 0/7] dpaa_eth: add XDP support

Enable XDP support for the QorIQ DPAA1 platforms.

Implement all the current actions (DROP, ABORTED, PASS, TX, REDIRECT). No Tx batching is added at this time.

Additional XDP_PACKET_HEADROOM bytes are reserved in each frame's headroom.

After transmit, a reference to the xdp_frame is saved in the buffer for clean-up on confirmation in a newly created structure for software annotations. DPAA_TX_PRIV_DATA_SIZE bytes are reserved in the buffer for storing this structure and the XDP program is restricted from accessing them.

The driver shares the egress frame queues used for XDP with the network stack. The DPAA driver is a LLTX driver so no explicit locking is required on transmission.

Changes in v2:
- warn only once if extracting the timestamp from a received frame fails in 2/7

Changes in v3:
- drop received S/G frames when XDP is enabled in 2/7

Changes in v4:
- report a warning if the MTU is too hight for running XDP in 2/7
- report an error if opening the device fails in the XDP setup in 2/7
- call xdp_rxq_info_is_reg() before unregistering in 4/7
- minor cleanups (remove unneeded variable, print error code) in 4/7
- add more details in the commit message in 4/7
- did not call qman_destroy_fq() in case of xdp_rxq_info_reg() failure since it would lead to a double free of the fq resources in 4/7

Changes in v5:
- report errors on XDP setup with extack in 2/7
- checkpath fix in 4/7
- add more details in the commit message in 4/7
- reduce the impact of the A050385 erratum workaround code on non-erratum platforms in 7/7

Camelia Groza (7):
dpaa_eth: add struct for software backpointers
dpaa_eth: add basic XDP support
dpaa_eth: limit the possible MTU range when XDP is enabled
dpaa_eth: add XDP_TX support
dpaa_eth: add XDP_REDIRECT support
dpaa_eth: rename current skb A050385 erratum workaround
dpaa_eth: implement the A050385 erratum workaround for XDP

 drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 465 +++++++++++++++++++++++--
 drivers/net/ethernet/freescale/dpaa/dpaa_eth.h |  13 +
 2 files changed, 448 insertions(+), 30 deletions(-)

--
1.9.1