Skip to content

Some cleanups and improvements for blk-iocost

Baolin Wang linux-block lkml 2 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 5 repliesApplied
  2. v17 patches 13 repliesSuperseded

Changes in v2 from the cover letter

- Add acked-by tag from Tejun.
- Drop 2 unnecessary patches.
- Move the related variable declarations inside the block together with the code in patch 3.
- Move the commit_weights() into ioc_check_iocgs().
- Move more related logics of adjusting base vrate into the ioc_adjust_base_vrate().
- Rename the new functions.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/5blk-iocost: Fix some typos in commentsblock/blk-iocost.c+6 -60 replies
2/5blk-iocost: Remove unnecessary advance declarationblock/blk-iocost.c+0 -20 replies
3/5blk-iocost: Move the usage ratio calculation to the correct placeblock/blk-iocost.c+23 -211 reply
4/5blk-iocost: Factor out the active iocgs' state check into a separate functionblock/blk-iocost.c+54 -401 reply
5/5blk-iocost: Factor out the base vrate change into a separate functionblock/blk-iocost.c+54 -451 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchTejun Heo
1/5A-b
2/5A-b
3/5A-b
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] Some cleanups and improvements for blk-iocost

Hi,

This patch set did some cleanups and improvements for blk-iocost, and no big functional changes. Please help to review. Thanks.

Changes from v1:
- Add acked-by tag from Tejun.
- Drop 2 unnecessary patches.
- Move the related variable declarations inside the block together with the code in patch 3.
- Move the commit_weights() into ioc_check_iocgs().
- Move more related logics of adjusting base vrate into the ioc_adjust_base_vrate().
- Rename the new functions.

Baolin Wang (5):
blk-iocost: Fix some typos in comments
blk-iocost: Remove unnecessary advance declaration
blk-iocost: Move the usage ratio calculation to the correct place
blk-iocost: Factor out the active iocgs' state check into a separate
function
blk-iocost: Factor out the base vrate change into a separate function

 block/blk-iocost.c | 251 +++++++++++++++++++++++++++++------------------------
 1 file changed, 137 insertions(+), 114 deletions(-)
Signature · 1 line
1.8.3.1