Skip to content

vidtv: address several issues at the driver

Mauro Carvalho Chehab linux-media lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest31 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/31media: vidtv: reorganize includesdrivers/media/test-drivers/vidtv/vidtv_bridge.c drivers/media/test-drivers/vidtv/vidtv_bridge.h drivers/media/test-drivers/vidtv/vidtv_channel.c +15 more+46 -460 replies
2/31media: vidtv: add error checksdrivers/media/test-drivers/vidtv/vidtv_bridge.c drivers/media/test-drivers/vidtv/vidtv_channel.c drivers/media/test-drivers/vidtv/vidtv_channel.h +3 more+291 -670 replies
3/31media: vidtv: don't use recursive functionsdrivers/media/test-drivers/vidtv/vidtv_psi.c+41 -340 replies
4/31media: vidtv: fix the name of the programdrivers/media/test-drivers/vidtv/vidtv_channel.c drivers/media/test-drivers/vidtv/vidtv_s302m.c+6 -60 replies
5/31media: vidtv: fix the tone generator logicdrivers/media/test-drivers/vidtv/vidtv_s302m.c drivers/media/test-drivers/vidtv/vidtv_s302m.h+5 -110 replies
6/31media: vidtv: fix some notes at the tone generatordrivers/media/test-drivers/vidtv/vidtv_s302m.c+20 -180 replies
7/31media: vidtv: avoid data copy when initializing the multiplexerdrivers/media/test-drivers/vidtv/vidtv_bridge.c drivers/media/test-drivers/vidtv/vidtv_mux.c drivers/media/test-drivers/vidtv/vidtv_mux.h+30 -280 replies
8/31media: vidtv: avoid copying data for PES structsdrivers/media/test-drivers/vidtv/vidtv_mux.c drivers/media/test-drivers/vidtv/vidtv_pes.c drivers/media/test-drivers/vidtv/vidtv_pes.h+102 -1080 replies
9/31media: vidtv: do some cleanups at the driverdrivers/media/test-drivers/vidtv/vidtv_bridge.c drivers/media/test-drivers/vidtv/vidtv_channel.c drivers/media/test-drivers/vidtv/vidtv_encoder.h +3 more+187 -1940 replies
10/31media: vidtv: remove some unused functionsdrivers/media/test-drivers/vidtv/vidtv_psi.c+0 -350 replies
11/31media: vidtv: pre-initialize mux arraysdrivers/media/test-drivers/vidtv/vidtv_mux.c+26 -200 replies
12/31media: vidtv: cleanup null packet initialization logicdrivers/media/test-drivers/vidtv/vidtv_mux.c+5 -40 replies
13/31media: vidtv: improve EIT datadrivers/media/test-drivers/vidtv/vidtv_channel.c+2 -20 replies
14/31media: vidtv: fix the network ID rangedrivers/media/test-drivers/vidtv/vidtv_bridge.c drivers/media/test-drivers/vidtv/vidtv_common.h+2 -20 replies
15/31media: vidtv: properly fill EIT service_iddrivers/media/test-drivers/vidtv/vidtv_channel.c drivers/media/test-drivers/vidtv/vidtv_psi.c drivers/media/test-drivers/vidtv/vidtv_psi.h+7 -40 replies
16/31media: vidtv: add a PID entry for the NIT tabledrivers/media/test-drivers/vidtv/vidtv_channel.c drivers/media/test-drivers/vidtv/vidtv_mux.c drivers/media/test-drivers/vidtv/vidtv_psi.c +1 more+39 -170 replies
17/31media: vidtv: fix service typedrivers/media/test-drivers/vidtv/vidtv_channel.c drivers/media/test-drivers/vidtv/vidtv_psi.h+2 -10 replies
18/31media: vidtv: fix service_id at SDT tabledrivers/media/test-drivers/vidtv/vidtv_channel.c drivers/media/test-drivers/vidtv/vidtv_psi.c drivers/media/test-drivers/vidtv/vidtv_psi.h+7 -40 replies
19/31media: vidtv: add date to the current eventdrivers/media/test-drivers/vidtv/vidtv_psi.c+41 -30 replies
20/31media: vidtv: simplify PSI write functiondrivers/media/test-drivers/vidtv/vidtv_psi.c+62 -660 replies
21/31media: vidtv: simplify the crc writing logicdrivers/media/test-drivers/vidtv/vidtv_psi.c+18 -210 replies
22/31media: vidtv: cleanup PSI descriptor write functiondrivers/media/test-drivers/vidtv/vidtv_psi.c+51 -530 replies
23/31media: vidtv: cleanup PSI table header functiondrivers/media/test-drivers/vidtv/vidtv_psi.c+19 -230 replies
24/31media: vidtv: cleanup PAT write functiondrivers/media/test-drivers/vidtv/vidtv_mux.c drivers/media/test-drivers/vidtv/vidtv_psi.c drivers/media/test-drivers/vidtv/vidtv_psi.h+32 -290 replies
25/31media: vidtv: cleanup PMT write table functiondrivers/media/test-drivers/vidtv/vidtv_mux.c drivers/media/test-drivers/vidtv/vidtv_psi.c drivers/media/test-drivers/vidtv/vidtv_psi.h+46 -490 replies
26/31media: vidtv: simplify SDT write functiondrivers/media/test-drivers/vidtv/vidtv_mux.c drivers/media/test-drivers/vidtv/vidtv_psi.c drivers/media/test-drivers/vidtv/vidtv_psi.h+46 -430 replies
27/31media: vidtv: simplify NIT write functiondrivers/media/test-drivers/vidtv/vidtv_mux.c drivers/media/test-drivers/vidtv/vidtv_psi.c drivers/media/test-drivers/vidtv/vidtv_psi.h+47 -480 replies
28/31media: vidtv: simplify EIT write functiondrivers/media/test-drivers/vidtv/vidtv_mux.c drivers/media/test-drivers/vidtv/vidtv_psi.c drivers/media/test-drivers/vidtv/vidtv_psi.h+46 -440 replies
29/31media: vidtv.rst: update vidtv documentationDocumentation/driver-api/media/drivers/vidtv.rst+72 -130 replies
30/31media: vidtv.rst: add kernel-doc markupsDocumentation/driver-api/media/drivers/vidtv.rst drivers/media/test-drivers/vidtv/vidtv_bridge.h drivers/media/test-drivers/vidtv/vidtv_channel.h +7 more+70 -320 replies
31/31media: vidtv: cleanup a few coding style issuesdrivers/media/test-drivers/vidtv/vidtv_bridge.c drivers/media/test-drivers/vidtv/vidtv_channel.c drivers/media/test-drivers/vidtv/vidtv_demod.c +3 more+6 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/31] vidtv: address several issues at the driver

This series is on the top of the series sent by Daniel:

	https://lore.kernel.org/linux-media/[email protected]/

It address several issues at the driver:
- Fix error logic, specially handling troubles with memory alloc functions;
- Fix issues at PMT, SDT and EIT tables, making EIT work fine (tested with Kaffeine);
- Fix issues at the tone generator;
- Pass MPEG-TS var structs as pointers;
- Avoid re-initializing struct fields;
- Improves driver documentation;
- Do several other cleanups and fixes.

As there are lots of fixes here, and the driver will only appear on Kernel 5.10, my plan is to merge those, together with Daniel's patches for Kernel 5.10.

Regards,
Mauro

Mauro Carvalho Chehab (31):
media: vidtv: reorganize includes
media: vidtv: add error checks
media: vidtv: don't use recursive functions
media: vidtv: fix the name of the program
media: vidtv: fix the tone generator logic
media: vidtv: fix some notes at the tone generator
media: vidtv: avoid data copy when initializing the multiplexer
media: vidtv: avoid copying data for PES structs
media: vidtv: do some cleanups at the driver
media: vidtv: remove some unused functions
media: vidtv: pre-initialize mux arrays
media: vidtv: cleanup null packet initialization logic
media: vidtv: improve EIT data
media: vidtv: fix the network ID range
media: vidtv: properly fill EIT service_id
media: vidtv: add a PID entry for the NIT table
media: vidtv: fix service type
media: vidtv: fix service_id at SDT table
media: vidtv: add date to the current event
media: vidtv: simplify PSI write function
media: vidtv: simplify the crc writing logic
media: vidtv: cleanup PSI descriptor write function
media: vidtv: cleanup PSI table header function
media: vidtv: cleanup PAT write function
media: vidtv: cleanup PMT write table function
media: vidtv: simplify SDT write function
media: vidtv: simplify NIT write function
media: vidtv: simplify EIT write function
media: vidtv.rst: update vidtv documentation
media: vidtv.rst: add kernel-doc markups
media: vidtv: cleanup a few coding style issues

 .../driver-api/media/drivers/vidtv.rst        |  112 +-
 .../media/test-drivers/vidtv/vidtv_bridge.c   |  118 +-
 .../media/test-drivers/vidtv/vidtv_bridge.h   |    4 +-
 .../media/test-drivers/vidtv/vidtv_channel.c  |  220 ++-
 .../media/test-drivers/vidtv/vidtv_channel.h  |    8 +-
 .../media/test-drivers/vidtv/vidtv_common.h   |    1 -
 .../media/test-drivers/vidtv/vidtv_demod.c    |    2 +-
 .../media/test-drivers/vidtv/vidtv_demod.h    |   11 +-
 .../media/test-drivers/vidtv/vidtv_encoder.h  |    6 +-
 drivers/media/test-drivers/vidtv/vidtv_mux.c  |  249 ++--
 drivers/media/test-drivers/vidtv/vidtv_mux.h  |   10 +-
 drivers/media/test-drivers/vidtv/vidtv_pes.c  |  179 ++-
 drivers/media/test-drivers/vidtv/vidtv_pes.h  |    8 +-
 drivers/media/test-drivers/vidtv/vidtv_psi.c  | 1185 +++++++++--------
 drivers/media/test-drivers/vidtv/vidtv_psi.h  |   62 +-
 .../media/test-drivers/vidtv/vidtv_s302m.c    |  114 +-
 .../media/test-drivers/vidtv/vidtv_s302m.h    |    8 +-
 drivers/media/test-drivers/vidtv/vidtv_ts.c   |    5 +-
 drivers/media/test-drivers/vidtv/vidtv_ts.h   |    5 +-
 .../media/test-drivers/vidtv/vidtv_tuner.c    |    5 +-
 .../media/test-drivers/vidtv/vidtv_tuner.h    |    1 +
 21 files changed, 1325 insertions(+), 988 deletions(-)
Signature · 1 line
2.28.0