Support symbolic links in paths in PSEUDO_IGNORE_PATHS
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest3 patches 0 repliesNew
- v35 patches 6 repliesSuperseded
- v24 patches 7 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 4 patches | 2 replies | Superseded |
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | lib/oe/path: Add canonicalize()meta/ | +21 | 0 replies | |
| 2/3 | bitbake.conf: Canonicalize paths in PSEUDO_IGNORE_PATHSmeta/ | +2 | 0 replies | |
| 3/3 | wic: Pass canonicalized paths in PSEUDO_IGNORE_PATHSscripts/ | +11 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.
Cover letter [PATCHv4 0/3] Support symbolic links in paths in PSEUDO_IGNORE_PATHS
The changes in this patch series aim to rectify a problem with pseudo and its support for ignoring paths. When pseudo compares a path to the paths specified in PSEUDO_IGNORE_PATHS, it uses a path that has been canonicalized. However, it does not canonicalize the paths in PSEUDO_IGNORE_PATHS itself and unless they are canonicalized, they will not match as intended. Thus the paths in PSEUDO_IGNORE_PATHS needs to be canonicalized. These patches do that by adding a new function oe.path.canonicalize(), which is then used when passing ${PSEUDO_IGNORE_PATHS} to pseudo.
There is also one patch that adds two patches to pseudo to clean up pseudo_client_ignore_path_chroot(), and they also plug a memory leak. The patches were brought about as I initially intended to do the canonicalization in pseudo itself in this function.
I have not tested the change to wic as we do not use it, though I do not expect it to be problematic.
PATCHv2:
* Removed some unrelated changes in the second patch.
PATCHv3:
* Handle an edge case in pseudo_client_ignore_path_chroot() in case PSEUDO_IGNORE_PATHS contains ",," or leading/trailing commas.
* Introduce oe.path.canonicalize() and use it instead of adding PSEUDO_IGNORE_REAL_PATHS as was previously done.
* Add similar code to wic.
PATCHv4:
* Rewrote oe.path.canonicalize() to maintain trailing slashes present in the paths.
//Peter
The following changes since commit 9826881036191be6ffba98c9bc8a86d1b852ff41:
build-appliance-image: Update to master head revision (2020-12-09 12:36:32 +0000)
are available in the Git repository at:
git://push.yoctoproject.org/poky-contrib pkj/pseudo-ignore
Peter Kjellerstedt (3):
lib/oe/path: Add canonicalize()
bitbake.conf: Canonicalize paths in PSEUDO_IGNORE_PATHS
wic: Pass canonicalized paths in PSEUDO_IGNORE_PATHS
meta/conf/bitbake.conf | 4 ++-- meta/lib/oe/path.py | 21 +++++++++++++++++++++ scripts/lib/wic/partition.py | 12 +++++++++++- 3 files changed, 34 insertions(+), 3 deletions(-)