Skip to content

midx: prevent against racily disappearing packs

Taylor Blau git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2packfile.c: protect against disappearing indexespackfile.c t/t5319-multi-pack-index.sh+24 -191 reply
2/2midx.c: protect against disappearing packsmidx.c t/t5319-multi-pack-index.sh+8 -21 reply

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchJeff King
1/2Co-authored-by
2/2Co-authored-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] midx: prevent against racily disappearing packs

Here are a couple of patches that Peff and I wrote after noticing a problem where racily disappearing .idx files can cause a segfault. While investigating, we fixed a related issue which is described and fixed in the second patch.

(I'm a little behind in responding to review on the reachability generation improvements patches, but had these in my backlog and they seemed relatively easy to send and remove from my TODO list. So, here they are :-).)

Thanks,
Taylor

Taylor Blau (2):
packfile.c: protect against disappearing indexes midx.c: protect against disappearing packs

 midx.c                      |  2 +-
 packfile.c                  | 19 ++-----------------
 t/t5319-multi-pack-index.sh | 30 ++++++++++++++++++++++++++++--
 3 files changed, 31 insertions(+), 20 deletions(-)

--
2.29.2.368.ge1806d1bdc