Skip to content

usb: typec: tps6598x: Export some power supply properties

Guido Günther linux-usb lkml 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 0 repliesNew
  2. v42 patches 3 repliesSuperseded
  3. v32 patches 4 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v21 patch0 repliesSuperseded
v11 patch2 repliesSuperseded

Changes in v5 from the cover letter

- As per review comments from Andy Shevchenko
https://lore.kernel.org/linux-usb/CAHp75Vfws_WMDxxpCpB1zSgbWucYx7-qeev6=mKE+znXSSPWSA@mail.gmail.com/T/#mb90b0f7dc49c4929590fa7fa0df53631b47a9285
- Use devm_kasprintf()
- Add reviewed by from Andy Shevchenko, thanks!
https://lore.kernel.org/linux-usb/CAHp75Vfws_WMDxxpCpB1zSgbWucYx7-qeev6=mKE+znXSSPWSA@mail.gmail.com/

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2usb: typec: tps6598x: Select USB_ROLE_SWITCH and REGMAP_I2Cdrivers/usb/typec/Kconfig+2 -20 replies
2/2usb: typec: tps6598x: Export some power supply propertiesdrivers/usb/typec/Kconfig drivers/usb/typec/tps6598x.c+104 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchHeikki KrogerusAndy Shevchenko
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/2] usb: typec: tps6598x: Export some power supply properties

This allows downstream supplies and userspace to detect whether external power is supplied.

The Librem 5 has the tp65982 in front of bq25980 charge controller. Since that is capable of sinking and sourcing power the online property helps to decide what to do. It also makes upower happy.

There will be follow up patches providing more properties but these need some more time to cook and i wanted to check if this is the right way to go?

changes from v4
- As per review comments from Andy Shevchenko
https://lore.kernel.org/linux-usb/CAHp75Vfws_WMDxxpCpB1zSgbWucYx7-qeev6=mKE+znXSSPWSA@mail.gmail.com/T/#mb90b0f7dc49c4929590fa7fa0df53631b47a9285
- Use devm_kasprintf()
- Add reviewed by from Andy Shevchenko, thanks!
https://lore.kernel.org/linux-usb/CAHp75Vfws_WMDxxpCpB1zSgbWucYx7-qeev6=mKE+znXSSPWSA@mail.gmail.com/

changes from v3
- As per review comments from Andy Shevchenko
https://lore.kernel.org/linux-usb/CAHp75VeLZtm85Y=3QMkPGb332wn05-zr-_mrrwXvnqLhazR1Gg@mail.gmail.com/
- Use positive conditionals
- Add reviewed by from Heikki Krogerus

    https://lore.kernel.org/linux-usb/[email protected]/T/#u
    https://lore.kernel.org/linux-usb/[email protected]/T/#u

- Fix typc vs typec typo in commit message

changes from v2
- As per kernel test robot
https://lore.kernel.org/linux-usb/[email protected]/
- Flip USB_ROLE_SWITCH and REGMAP_I2C from 'depends on' to 'select' This matches tcpm and avoids a config symbol recursion which went unnoticed on my arm64 build but trips up x86_64.

changes from v1
- As per review comments from Heikki Krogerus
https://lore.kernel.org/linux-usb/[email protected]/
- select POWER_SUPPLY
- use POWER_SUPPLY_USB_TYPE_PD when a PD contract got negotiated

Guido Günther (2):
usb: typec: tps6598x: Select USB_ROLE_SWITCH and REGMAP_I2C
usb: typec: tps6598x: Export some power supply properties

 drivers/usb/typec/Kconfig    |   5 +-
 drivers/usb/typec/tps6598x.c | 103 +++++++++++++++++++++++++++++++++++
 2 files changed, 106 insertions(+), 2 deletions(-)
Signature · 1 line
2.29.2

Read the cover letter in its thread