Skip to content

mptcp: avoid workqueue usage for data

Paolo Abeni mptcp netdev 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 7 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/6mptcp: open code mptcp variant for lock_sockinclude/net/sock.h net/core/sock.c net/mptcp/protocol.h+15 -11 reply
2/6mptcp: implement wmem reservationnet/mptcp/protocol.c net/mptcp/protocol.h+86 -71 reply
3/6mptcp: protect the rx path with the msk socket spinlocknet/mptcp/protocol.c net/mptcp/protocol.h+107 -471 reply
4/6mptcp: allocate TX skbs in msk contextnet/mptcp/protocol.c net/mptcp/protocol.h+210 -421 reply
5/6mptcp: avoid a few atomic ops in the rx pathnet/mptcp/mptcp_diag.c net/mptcp/options.c net/mptcp/protocol.c +1 more+34 -431 reply
6/6mptcp: use mptcp release_cb for delayed tasksnet/mptcp/options.c net/mptcp/protocol.c net/mptcp/protocol.h +1 more+168 -1171 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchFlorian WestphalMat Martineau
1/6A-b R-b
2/6A-b R-b
3/6A-b R-b
4/6A-b R-b
5/6A-b R-b
6/6A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/6] mptcp: avoid workqueue usage for data

The current locking schema used to protect the MPTCP data-path requires the usage of the MPTCP workqueue to process the incoming data, depending on trylock result.

The above poses scalability limits and introduces random delays in MPTCP-level acks.

With this series we use a single spinlock to protect the MPTCP data-path, removing the need for workqueue and delayed ack usage.

This additionally reduces the number of atomic operations required per packet and cleans-up considerably the poll/wake-up code.

Paolo Abeni (6):
mptcp: open code mptcp variant for lock_sock
mptcp: implement wmem reservation
mptcp: protect the rx path with the msk socket spinlock
mptcp: allocate TX skbs in msk context
mptcp: avoid a few atomic ops in the rx path
mptcp: use mptcp release_cb for delayed tasks

 include/net/sock.h     |   1 +
 net/core/sock.c        |   2 +-
 net/mptcp/mptcp_diag.c |   2 +-
 net/mptcp/options.c    |  47 +--
 net/mptcp/protocol.c   | 733 ++++++++++++++++++++++++++++++-----------
 net/mptcp/protocol.h   |  34 +-
 net/mptcp/subflow.c    |  14 +-
 7 files changed, 598 insertions(+), 235 deletions(-)
Signature · 1 line
2.26.2