Skip to content

membarrier fixes

Andy Lutomirski lkml stable 3 versions – Applied

Status from this message: The following commit has been merged into the x86/urgent branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 6 repliesApplied
  2. v24 patches 3 repliesSuperseded
  3. v13 patches 14 repliesSuperseded

Changes in v3 from the cover letter

- Added reviewed-bys
- Don't rseq_preempt the caller (Mathieu)
- Fix single-thread short circuit (Mathieu)

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/4x86/membarrier: Get rid of a dubious optimizationarch/x86/include/asm/sync_core.h arch/x86/mm/tlb.c+13 -61 reply
2/4membarrier: Add an actual barrier before rseq_preempt()kernel/sched/membarrier.c+8 -02 replies
3/4membarrier: Explicitly sync remote cores when SYNC_CORE is requestedkernel/sched/membarrier.c+18 -01 reply
4/4membarrier: Execute SYNC_CORE on the calling threadkernel/sched/membarrier.c+33 -182 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMathieu Desnoyers
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] membarrier fixes

Various membarrier fixes.

Changes from v2:
- Added reviewed-bys
- Don't rseq_preempt the caller (Mathieu)
- Fix single-thread short circuit (Mathieu)

Changes from v1:
- patch 1: comment fixes from Mathieu
- patch 2: improved comments
- patch 3: split out as a separate patch
- patch 4: now has a proper explanation

Mathieu, I think we have to make sync_core sync the caller. See patch 4.

Andy Lutomirski (4):
x86/membarrier: Get rid of a dubious optimization
membarrier: Add an actual barrier before rseq_preempt()
membarrier: Explicitly sync remote cores when SYNC_CORE is requested
membarrier: Execute SYNC_CORE on the calling thread

 arch/x86/include/asm/sync_core.h |  9 ++--
 arch/x86/mm/tlb.c                | 10 ++++-
 kernel/sched/membarrier.c        | 77 ++++++++++++++++++++++++--------
 3 files changed, 72 insertions(+), 24 deletions(-)
Signature · 1 line
2.28.0