Skip to content

add support for RFC 8335 PROBE

Andreas Roeseler netdev 6 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (refs/heads/master):

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest6 patches 3 repliesApplied 6/6
  2. v56 patches 5 repliesSuperseded
  3. v45 patches 8 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v35 patches5 repliesSuperseded
v25 patches6 repliesSuperseded
v16 patches2 repliesSuperseded

Changes in v6 from the cover letter

- Add documentation for icmp_echo_enable_probe sysctl
- Remove RCU locking around ipv6_dev_find()
- Assign iio based on ctype

Patches in v6 All 6 applied

#Subject and filesSizeRepliesApplied
1/6icmp: add support for RFC 8335 PROBEinclude/uapi/linux/icmp.h+42 -03 repliesApplied
2/6ICMPV6: add support for RFC 8335 PROBEinclude/uapi/linux/icmpv6.h+3 -00 repliesApplied
3/6net: add sysctl for enabling RFC 8335 PROBE messagesDocumentation/networking/ip-sysctl.rst include/net/netns/ipv4.h net/ipv4/sysctl_net_ipv4.c+16 -00 repliesApplied
4/6net: add support for sending RFC 8335 PROBE messagesnet/ipv4/ping.c+3 -10 repliesApplied
5/6ipv6: add ipv6_dev_find to stubsinclude/net/ipv6_stubs.h net/ipv6/addrconf_core.c net/ipv6/af_inet6.c+10 -00 repliesApplied
6/6icmp: add response to RFC 8335 PROBE messagesnet/ipv4/icmp.c+121 -130 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [PATCH net-next V6 0/6] add support for RFC 8335 PROBE

The popular utility ping has several severe limitations, such as the inability to query specific interfaces on a node and requiring bidirectional connectivity between the probing and probed interfaces. RFC 8335 attempts to solve these limitations by creating the new utility PROBE which is a specialized ICMP message that makes use of the ICMP Extension Structure outlined in RFC 4884.

This patchset adds definitions for the ICMP Extended Echo Request and Reply (PROBE) types for both IPV4 and IPV6, adds a sysctl to enable responses to PROBE messages, expands the list of supported ICMP messages to accommodate PROBE types, adds ipv6_dev_find into ipv6_stubs, and adds functionality to respond to PROBE requests.

Changes:
v1 -> v2:
- Add AFI definitions
- Switch to functions such as dev_get_by_name and ip_dev_find to lookup net devices

v2 -> v3:
Suggested by Willem de Bruijn <[email protected]>
- Add verification of incoming messages before looking up netdev
- Add prefix for PROBE specific defined variables
- Use proc_dointvec_minmax with zero and one for sysctl
- Create struct icmp_ext_echo_iio for parsing incoming packets

- Include net/addrconf.h library for ipv6_dev_find

v3 -> v4:
- Use in_addr instead of __be32 for storing IPV4 addresses
- Use IFNAMSIZ to statically allocate space for name in icmp_ext_echo_iio
Suggested by Willem de Bruijn <[email protected]>
- Use skb_header_pointer to verify fields in incoming message
- Add check to ensure that extobj_hdr.length is valid
- Check to ensure object payload is padded with ASCII NULL characters when probing by name, as specified by RFC 8335
- Statically allocate buff using IFNAMSIZ
- Add rcu blocking around ipv6_dev_find
- Use __in_dev_get_rcu to access IPV4 addresses of identified net_device
- Remove check for ICMPV6 PROBE types

v4 -> v5:
- Statically allocate buff to size IFNAMSIZ on declaration
- Remove goto probe in favor of single branch
- Remove strict check for incoming PROBE request padding to nearest 32-bit boundary

v5 -> v6:
- Add documentation for icmp_echo_enable_probe sysctl
- Remove RCU locking around ipv6_dev_find()
- Assign iio based on ctype

Andreas Roeseler (6):
icmp: add support for RFC 8335 PROBE
ICMPV6: add support for RFC 8335 PROBE
net: add sysctl for enabling RFC 8335 PROBE messages
net: add support for sending RFC 8335 PROBE messages
ipv6: add ipv6_dev_find to stubs
icmp: add response to RFC 8335 PROBE messages

 Documentation/networking/ip-sysctl.rst |   6 ++
 include/net/ipv6_stubs.h               |   2 +
 include/net/netns/ipv4.h               |   1 +
 include/uapi/linux/icmp.h              |  42 ++++++++
 include/uapi/linux/icmpv6.h            |   3 +
 net/ipv4/icmp.c                        | 134 ++++++++++++++++++++++---
 net/ipv4/ping.c                        |   4 +-
 net/ipv4/sysctl_net_ipv4.c             |   9 ++
 net/ipv6/addrconf_core.c               |   7 ++
 net/ipv6/af_inet6.c                    |   1 +
 10 files changed, 195 insertions(+), 14 deletions(-)
Signature · 1 line
2.17.1