Skip to content

btrfs: fix transaction leaks and crashes during unmount

[email protected] linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5btrfs: fix transaction leak and crash after RO remount caused by qgroup rescanfs/btrfs/qgroup.c fs/btrfs/super.c+18 -32 replies
2/5btrfs: fix transaction leak and crash after cleaning up orphans on RO mountfs/btrfs/disk-io.c+1 -43 replies
3/5btrfs: fix race between RO remount and the cleaner taskfs/btrfs/ctree.h fs/btrfs/disk-io.c fs/btrfs/super.c +1 more+44 -70 replies
4/5btrfs: add assertion for empty list of transactions at late stage of umountfs/btrfs/disk-io.c+3 -00 replies
5/5btrfs: run delayed iputs when remounting RO to avoid leaking themfs/btrfs/super.c+10 -00 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchFabian VogtJosef Bacik
SeriesR-b
1/5T-b
2/5T-b
3/5T-b
4/5T-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] btrfs: fix transaction leaks and crashes during unmount

From: Filipe Manana <[email protected]>

There are some cases where we can leak a transaction and crash during unmount after remounting the filesystem in RO mode or mounting RO. These issues were actually being hit by automated tests from the openQA for openSUSE Tumbleweed (bugzilla https://bugzilla.suse.com/show_bug.cgi?id=1164503).

Filipe Manana (5):
btrfs: fix transaction leak and crash after RO remount caused by
qgroup rescan
btrfs: fix transaction leak and crash after cleaning up orphans on RO
mount
btrfs: fix race between RO remount and the cleaner task
btrfs: add assertion for empty list of transactions at late stage of
umount
btrfs: run delayed iputs when remounting RO to avoid leaking them

 fs/btrfs/ctree.h   | 20 +++++++++++++++++++-
 fs/btrfs/disk-io.c | 13 ++++++++-----
 fs/btrfs/qgroup.c  | 13 ++++++++++---
 fs/btrfs/super.c   | 40 +++++++++++++++++++++++++++++++++++++---
 fs/btrfs/volumes.c |  4 ++--
 5 files changed, 76 insertions(+), 14 deletions(-)
Signature · 1 line
2.28.0