Skip to content

drm/i915: refactor intel display

Jani Nikula intel-gfx oe-kbuild oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v4 Latest11 patches 6 repliesIn review

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11drm/i915/display: move needs_modeset to an inline in headerdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display_types.h+42 -420 replies
2/11drm/i915/display: move to_intel_frontbuffer to headerdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display_types.h+6 -60 replies
3/11drm/i915/display: fix misused commadrivers/gpu/drm/i915/display/intel_display.c+2 -10 replies
4/11drm/i915: refactor cursor code out of i915_display.cdrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/display/intel_cursor.c drivers/gpu/drm/i915/display/intel_cursor.h +2 more+838 -7900 replies
5/11drm/i915: refactor some crtc code out of intel display.drivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/display/intel_crtc.c drivers/gpu/drm/i915/display/intel_crtc.h +1 more+977 -9330 replies
6/11drm/i915: refactor pll code out into intel_dpll.cdrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display.h +3 more+1414 -13911 reply
7/11drm/i915: split fdi code out from intel_display.cdrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display_types.h +2 more+718 -6820 replies
8/11drm/i915: migrate hsw fdi code to new file.drivers/gpu/drm/i915/display/intel_crt.c drivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_ddi.h +2 more+202 -1911 reply
9/11drm/i915: migrate skl planes code new filedrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/display/intel_atomic_plane.c drivers/gpu/drm/i915/display/intel_crtc.c +5 more+2931 -28782 replies
10/11drm/i915: move pipe update code into crtc.drivers/gpu/drm/i915/display/intel_crtc.c drivers/gpu/drm/i915/display/intel_sprite.c+230 -2281 reply
11/11drm/i915: split fb scalable checks into g4x and skl versionsdrivers/gpu/drm/i915/display/intel_gen9_plane.c drivers/gpu/drm/i915/display/intel_sprite.c+5 -61 reply

Reviews trailers per patch

7 of 11 patches have a Reviewed-by or Acked-by.

PatchVille Syrjälä
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11
6/11R-b
7/11
8/11
9/11
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Intel-gfx] [PATCH v4 00/11] drm/i915: refactor intel display

This is Dave's intel_display.c refactoring series [1] with some minor issues addressed, to get CI results among other things.

I've reviewed and fixed any remaining minor issues I spotted in patches 1-8. I'm aware there may be things to improve, but I think this is overall forward progress and cleanup that's long overdue. I'm prepared to merge patches 1-8 unless there are strong objections.

I ran out of steam a little with patches 9-11, and haven't reviewed them. They're included here just for completeness.

BR,
Jani.

[1] https://patchwork.freedesktop.org/series/84812/

Dave Airlie (11):
drm/i915/display: move needs_modeset to an inline in header drm/i915/display: move to_intel_frontbuffer to header drm/i915/display: fix misused comma
drm/i915: refactor cursor code out of i915_display.c drm/i915: refactor some crtc code out of intel display. drm/i915: refactor pll code out into intel_dpll.c drm/i915: split fdi code out from intel_display.c drm/i915: migrate hsw fdi code to new file. drm/i915: migrate skl planes code new file drm/i915: move pipe update code into crtc. drm/i915: split fb scalable checks into g4x and skl versions

 drivers/gpu/drm/i915/Makefile                 |     5 +
 .../gpu/drm/i915/display/intel_atomic_plane.c |    76 -
 drivers/gpu/drm/i915/display/intel_crt.c      |     1 +
 drivers/gpu/drm/i915/display/intel_crtc.c     |  1187 +
 drivers/gpu/drm/i915/display/intel_crtc.h     |    22 +
 drivers/gpu/drm/i915/display/intel_cursor.c   |   806 +
 drivers/gpu/drm/i915/display/intel_cursor.h   |    17 +
 drivers/gpu/drm/i915/display/intel_ddi.c      |   197 +-
 drivers/gpu/drm/i915/display/intel_ddi.h      |    14 +-
 drivers/gpu/drm/i915/display/intel_display.c  | 20019 ++++++----------
 drivers/gpu/drm/i915/display/intel_display.h  |    46 +-
 .../drm/i915/display/intel_display_types.h    |    55 +
 drivers/gpu/drm/i915/display/intel_dpll.c     |  1363 ++
 drivers/gpu/drm/i915/display/intel_dpll.h     |    23 +
 drivers/gpu/drm/i915/display/intel_fdi.c      |   857 +
 drivers/gpu/drm/i915/display/intel_fdi.h      |    29 +
 .../gpu/drm/i915/display/intel_gen9_plane.c   |  2832 +++
 drivers/gpu/drm/i915/display/intel_sprite.c   |  1712 +-
 18 files changed, 14739 insertions(+), 14522 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_crtc.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_crtc.h
 create mode 100644 drivers/gpu/drm/i915/display/intel_cursor.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_cursor.h
 create mode 100644 drivers/gpu/drm/i915/display/intel_dpll.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_dpll.h
 create mode 100644 drivers/gpu/drm/i915/display/intel_fdi.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_fdi.h
 create mode 100644 drivers/gpu/drm/i915/display/intel_gen9_plane.c
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx