Skip to content

Testing improvements

Glenn Washburn grub-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5tests: Exit with skipped exit code when test not performedtests/core_compress_test.in tests/pseries_test.in+2 -20 replies
2/5tests: Make sure LANG is set properly for iso9660_testtests/iso9660_test.in+6 -00 replies
3/5tests: Make setup errors in grub-fs-tester hard errorstests/util/grub-fs-tester.in+6 -50 replies
4/5tests: Fix partmap_test for arm*-efi, disk numbering has changedtests/partmap_test.in+1 -10 replies
5/5tests: Comment failing functional tests until we can get them working againgrub-core/tests/lib/functional_test.c+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] Testing improvements

I've been working on getting continuous integration working in gitlab where testing is being done in an Ubuntu image. This patch series improves various tests. I've ordered the patches starting with the least controversial patches. The last two patches I suspect may have some deserve some attention.

Patch 4 allows the partmap_test to pass. I'm not sure why the number of the device has changed from the setup this test was previously working on. I suspect it could be either because I'm using a newer qemu or because I'm using a new firmware/bios.

Patch 5 disables functional tests that have been failing for a long time, by commenting them out. When someone gets around to fixing them, they can be uncommented. But as it is, they've been failing for some time and people ignore those failures. This isn't so nice with a continuous integration system that largely expects tests to be passing, so it can detect when there are new failures.

Glenn

Glenn Washburn (5):
tests: Exit with skipped exit code when test not performed
tests: Make sure LANG is set properly for iso9660_test
tests: Make setup errors in grub-fs-tester hard errors
tests: Fix partmap_test for arm*-efi, disk numbering has changed
tests: Comment failing functional tests until we can get them working
again

 grub-core/tests/lib/functional_test.c |  6 +++---
 tests/core_compress_test.in           |  2 +-
 tests/iso9660_test.in                 |  6 ++++++
 tests/partmap_test.in                 |  2 +-
 tests/pseries_test.in                 |  2 +-
 tests/util/grub-fs-tester.in          | 11 ++++++-----
 6 files changed, 18 insertions(+), 11 deletions(-)
Signature · 1 line
2.27.0