Skip to content

drm/i915/dp: split out pps and aux

Jani Nikula intel-gfx 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest17 patches 15 repliesIn review
  2. v113 patches 18 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17drm/i915/pps: abstract panel power sequencer from intel_dp.cdrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_display_power.c +4 more+1443 -13892 replies
2/17drm/i915/pps: rename pps_{, un}lock -> intel_pps_{, un}lockdrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_pps.c drivers/gpu/drm/i915/display/intel_pps.h+25 -240 replies
3/17drm/i915/pps: rename intel_edp_backlight_* to intel_pps_backlight_*drivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_pps.c drivers/gpu/drm/i915/display/intel_pps.h+11 -110 replies
4/17drm/i915/pps: rename intel_edp_panel_* to intel_pps_*drivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_pps.c +1 more+22 -241 reply
5/17drm/i915/pps: rename edp_panel_* to intel_pps_*_unlockeddrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_pps.c drivers/gpu/drm/i915/display/intel_pps.h+26 -261 reply
6/17drm/i915/pps: abstract intel_pps_vdd_off_syncdrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_pps.c drivers/gpu/drm/i915/display/intel_pps.h+21 -301 reply
7/17drm/i915/pps: add higher level intel_pps_init() calldrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_pps.c drivers/gpu/drm/i915/display/intel_pps.h+17 -120 replies
8/17drm/i915/pps: abstract intel_pps_encoder_reset()drivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_pps.c drivers/gpu/drm/i915/display/intel_pps.h+25 -190 replies
9/17drm/i915/pps: rename intel_dp_check_edp to intel_pps_check_power_unlockeddrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_pps.c drivers/gpu/drm/i915/display/intel_pps.h+3 -30 replies
10/17drm/i915/pps: rename intel_power_sequencer_reset to intel_pps_reset_alldrivers/gpu/drm/i915/display/intel_display_power.c drivers/gpu/drm/i915/display/intel_pps.c drivers/gpu/drm/i915/display/intel_pps.h+5 -60 replies
11/17drm/i915/pps: add locked intel_pps_wait_power_cycledrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_pps.c drivers/gpu/drm/i915/display/intel_pps.h+14 -90 replies
12/17drm/i915/pps: rename vlv_init_panel_power_sequencer to vlv_pps_initdrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_pps.c drivers/gpu/drm/i915/display/intel_pps.h+5 -50 replies
13/17drm/i915/pps: rename intel_dp_init_panel_power_sequencer* functionsdrivers/gpu/drm/i915/display/intel_pps.c+16 -212 replies
14/17drm/i915/pps: refactor init abstractionsdrivers/gpu/drm/i915/display/intel_pps.c+10 -233 replies
15/17drm/i915/pps: move pps code over from intel_display.c and refactordrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display.h drivers/gpu/drm/i915/display/intel_pps.c +2 more+42 -383 replies
16/17drm/i915/dp: abstract struct intel_dp pps members to a sub-structdrivers/gpu/drm/i915/display/intel_display_debugfs.c drivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/display/intel_dp.c +1 more+140 -1351 reply
17/17drm/i915/dp: split out aux functionality to intel_dp_aux.cdrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp_aux.c +1 more+707 -6791 reply

Reviews trailers per patch

15 of 17 patches have a Reviewed-by or Acked-by.

PatchAnshuman Gupta
1/17R-b
2/17R-b
3/17R-b
4/17R-b
5/17R-b
6/17R-b
7/17R-b
8/17R-b
9/17R-b
10/17R-b
11/17R-b
12/17R-b
13/17R-b
14/17R-b
15/17R-b
16/17
17/17

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Intel-gfx] [PATCH v2 00/17] drm/i915/dp: split out pps and aux

This is v2 of [1], with comments from Anshuman addressed, and a few additional patches at the end.

BR,
Jani.

[1] https://patchwork.freedesktop.org/series/85167/

Jani Nikula (17):
drm/i915/pps: abstract panel power sequencer from intel_dp.c drm/i915/pps: rename pps_{,un}lock -> intel_pps_{,un}lock drm/i915/pps: rename intel_edp_backlight_* to intel_pps_backlight_* drm/i915/pps: rename intel_edp_panel_* to intel_pps_* drm/i915/pps: rename edp_panel_* to intel_pps_*_unlocked drm/i915/pps: abstract intel_pps_vdd_off_sync drm/i915/pps: add higher level intel_pps_init() call drm/i915/pps: abstract intel_pps_encoder_reset() drm/i915/pps: rename intel_dp_check_edp to
intel_pps_check_power_unlocked
drm/i915/pps: rename intel_power_sequencer_reset to
intel_pps_reset_all
drm/i915/pps: add locked intel_pps_wait_power_cycle drm/i915/pps: rename vlv_init_panel_power_sequencer to vlv_pps_init drm/i915/pps: rename intel_dp_init_panel_power_sequencer* functions drm/i915/pps: refactor init abstractions
drm/i915/pps: move pps code over from intel_display.c and refactor drm/i915/dp: abstract struct intel_dp pps members to a sub-struct drm/i915/dp: split out aux functionality to intel_dp_aux.c

 drivers/gpu/drm/i915/Makefile                 |    2 +
 drivers/gpu/drm/i915/display/intel_ddi.c      |    9 +-
 drivers/gpu/drm/i915/display/intel_display.c  |   41 +-
 drivers/gpu/drm/i915/display/intel_display.h  |    1 -
 .../drm/i915/display/intel_display_debugfs.c  |    8 +-
 .../drm/i915/display/intel_display_power.c    |    6 +-
 .../drm/i915/display/intel_display_types.h    |   61 +-
 drivers/gpu/drm/i915/display/intel_dp.c       | 2249 +----------------
 drivers/gpu/drm/i915/display/intel_dp.h       |    5 +-
 drivers/gpu/drm/i915/display/intel_dp_aux.c   |  687 +++++
 drivers/gpu/drm/i915/display/intel_dp_aux.h   |   18 +
 drivers/gpu/drm/i915/display/intel_pps.c      | 1406 +++++++++++
 drivers/gpu/drm/i915/display/intel_pps.h      |   52 +
 drivers/gpu/drm/i915/i915_drv.c               |    1 +
 14 files changed, 2312 insertions(+), 2234 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_dp_aux.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_dp_aux.h
 create mode 100644 drivers/gpu/drm/i915/display/intel_pps.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_pps.h
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx