Skip to content

dcb: Support APP, DCBX objects

Petr Machata netdev 2 versions – Applied

Status from this message: applied to iproute2-next.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 1 replyApplied
  2. v19 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- Two patches dropped and sent to iproute2 branch as "dcb: Fixes". This patch set now depends on that one.
- Patch #5:
- Make it -N / --Numeric instead of -n / --no-nice-names
- Rename the flag from no_nice_names to numeric as well
- Patch #6:
- Adjust to s/no_nice_names/numeric/ from another patch.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/7lib: rt_names: Add rtnl_dsfield_get_name()include/rt_names.h lib/rt_names.c+17 -40 replies
2/7lib: Generalize parse_mapping()include/utils.h lib/utils.c+36 -60 replies
3/7dcb: Generalize dcb_set_attribute()dcb/dcb.c dcb/dcb.h+98 -80 replies
4/7dcb: Generalize dcb_get_attribute()dcb/dcb.c dcb/dcb.h+68 -150 replies
5/7dcb: Support -N to suppress translation to human-readable namesdcb/dcb.c dcb/dcb.h man/man8/dcb.8+13 -20 replies
6/7dcb: Add a subtool for the DCB APP objectdcb/Makefile dcb/dcb.c dcb/dcb.h +3 more+1052 -30 replies
7/7dcb: Add a subtool for the DCBX objectdcb/Makefile dcb/dcb.c dcb/dcb.h +2 more+308 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH iproute2-next v2 0/7] dcb: Support APP, DCBX objects

Add support to the dcb tool for the following two DCB objects:

- APP, which allows configuration of traffic prioritization rules based on several possible packet headers.

- DCBX, which is a 1-byte bitfield of flags that configure whether the DCBX protocol is implemented in the device or in the host, and which version of the protocol should be used.

Patch #1 adds a new helper for finding a name of a given dsfield value. This is useful for APP DSCP-to-priority rules, which can use human-readable DSCP names.

Patches #2, #3 and #4 extend existing interfaces for, respectively, parsing of the X:Y mappings, for setting a DCB object, and for getting a DCB object.

In patch #5, support for the command line argument -N / --Numeric is added. The APP tool later uses it to decide whether to format DSCP values as human-readable strings or as plain numbers.

Patches #6 and #7 add the subtools themselves and their man pages.

v2:
- Two patches dropped and sent to iproute2 branch as "dcb: Fixes". This patch set now depends on that one.
- Patch #5:
- Make it -N / --Numeric instead of -n / --no-nice-names
- Rename the flag from no_nice_names to numeric as well
- Patch #6:
- Adjust to s/no_nice_names/numeric/ from another patch.

Petr Machata (7):
lib: rt_names: Add rtnl_dsfield_get_name()
lib: Generalize parse_mapping()
dcb: Generalize dcb_set_attribute()
dcb: Generalize dcb_get_attribute()
dcb: Support -N to suppress translation to human-readable names
dcb: Add a subtool for the DCB APP object
dcb: Add a subtool for the DCBX object

 dcb/Makefile        |   8 +-
 dcb/dcb.c           | 193 +++++++++--
 dcb/dcb.h           |  20 ++
 dcb/dcb_app.c       | 796 ++++++++++++++++++++++++++++++++++++++++++++
 dcb/dcb_dcbx.c      | 192 +++++++++++
 include/rt_names.h  |   1 +
 include/utils.h     |   5 +
 lib/rt_names.c      |  20 +-
 lib/utils.c         |  37 +-
 man/man8/dcb-app.8  | 237 +++++++++++++
 man/man8/dcb-dcbx.8 | 108 ++++++
 man/man8/dcb.8      |  12 +-
 12 files changed, 1591 insertions(+), 38 deletions(-)
 create mode 100644 dcb/dcb_app.c
 create mode 100644 dcb/dcb_dcbx.c
 create mode 100644 man/man8/dcb-app.8
 create mode 100644 man/man8/dcb-dcbx.8
Signature · 1 line
2.26.2