Skip to content

Misc vt82c686b clean ups

BALATON Zoltan via qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 7 repliesIn review
  2. v112 patches 18 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10vt82c686: Rename AC97/MC97 parts from VT82C686B to VIAhw/isa/vt82c686.c+14 -140 replies
2/10vt82c686: Remove unnecessary _DEVICE suffix from type macroshw/isa/vt82c686.c+23 -250 replies
3/10vt82c686b: Rename VT82C686B to VT82C686B_ISAhw/isa/vt82c686.c+10 -101 reply
4/10vt82c686: Remove vt82c686b_[am]c97_init() functionshw/isa/vt82c686.c hw/mips/fuloong2e.c include/hw/isa/vt82c686.h+8 -271 reply
5/10vt82c686: Split off via-[am]c97 into separate file in hw/audiohw/audio/meson.build hw/audio/via-ac97.c hw/isa/vt82c686.c+107 -910 replies
6/10audio/via-ac97: Simplify code and set user_creatable to falsehw/audio/via-ac97.c+19 -321 reply
7/10vt82c686: Remove legacy vt82c686b_isa_init() functionhw/isa/vt82c686.c hw/mips/fuloong2e.c include/hw/isa/vt82c686.h+4 -120 replies
8/10vt82c686: Remove legacy vt82c686b_pm_init() functionhw/isa/vt82c686.c hw/mips/fuloong2e.c include/hw/isa/vt82c686.h+5 -230 replies
9/10vt82c686: Convert debug printf to trace pointshw/isa/trace-events hw/isa/vt82c686.c+21 -363 replies
10/10vt82c686: Remove unneeded includes and defineshw/isa/vt82c686.c+0 -51 reply

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-Daudé
1/10R-b
2/10R-b
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/10] Misc vt82c686b clean ups

I'm sending this v2 with tags added and small edits after Philippe's review for now, maybe these are already good to go. I've taken out a few patches that may need some more work but I've run out of free time for now so will have to come back to them later. I still could not cleanly add the VT8231 model which may need some more reorganising and found a few issues with the existin 868B that may need to be fixed first so those left out patches may change anyway so will be included in a future series.

Regards,
BALATON Zoltan

BALATON Zoltan (10):
vt82c686: Rename AC97/MC97 parts from VT82C686B to VIA
vt82c686: Remove unnecessary _DEVICE suffix from type macros
vt82c686b: Rename VT82C686B to VT82C686B_ISA
vt82c686: Remove vt82c686b_[am]c97_init() functions
vt82c686: Split off via-[am]c97 into separate file in hw/audio audio/via-ac97: Simplify code and set user_creatable to false
vt82c686: Remove legacy vt82c686b_isa_init() function
vt82c686: Remove legacy vt82c686b_pm_init() function
vt82c686: Convert debug printf to trace points
vt82c686: Remove unneeded includes and defines

 hw/audio/meson.build      |   1 +
 hw/audio/via-ac97.c       |  93 ++++++++++++++++
 hw/isa/trace-events       |   6 ++
 hw/isa/vt82c686.c         | 217 +++++---------------------------------
 hw/mips/fuloong2e.c       |  13 ++-
 include/hw/isa/vt82c686.h |  12 +--
 6 files changed, 139 insertions(+), 203 deletions(-)
 create mode 100644 hw/audio/via-ac97.c
Signature · 1 line
2.21.3