Skip to content

avoid peeking into `struct lock_file`

Martin Ågren git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5builtin/gc: don't peek into `struct lock_file`builtin/gc.c+3 -30 replies
2/5commit-graph: don't peek into `struct lock_file`commit-graph.c+3 -30 replies
3/5midx: don't peek into `struct lock_file`midx.c+1 -10 replies
4/5refs/files-backend: don't peek into `struct lock_file`refs/files-backend.c+2 -20 replies
5/5read-cache: try not to peek into `struct {lock_,temp}file`read-cache.c+6 -60 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDerrick Stolee
SeriesR-b
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] avoid peeking into `struct lock_file`

I made a comment in [1] about how we could avoid peeking into a struct lock_file and instead use a helper function that we happen to have at our disposal. I then grepped around a bit and found that we're pretty good at avoiding such peeking at the moment, but that we could do a bit better.

Here's a series to avoid such lk.tempfile.foo in favor of get_lock_file_foo(&lk).

[1] https://lore.kernel.org/git/CAN0heSrOKr--GenbowHP+iwkijbg5pCeJLq+wz6NXCXTsfcvGg@mail.gmail.com/

Martin Ågren (5):
builtin/gc: don't peek into struct lock_file
commit-graph: don't peek into struct lock_file
midx: don't peek into struct lock_file refs/files-backend: don't peek into struct lock_file
read-cache: try not to peek into struct {lock_,temp}file

 builtin/gc.c         |  6 +++---
 commit-graph.c       |  6 +++---
 midx.c               |  2 +-
 read-cache.c         | 12 ++++++------
 refs/files-backend.c |  4 ++--
 5 files changed, 15 insertions(+), 15 deletions(-)
Signature · 1 line
2.30.0