Skip to content

mptcp: re-enable snd buf autotune

Paolo Abeni mptcp 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 2 repliesIn review
  2. v24 patches 5 repliesSuperseded
  3. v13 patches 0 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4mptcp: always graft subflow socket to parent.net/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/subflow.c+14 -260 replies
2/4mptcp: re-enable sndbuf autotunenet/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/subflow.c+49 -330 replies
3/4mptcp: do not queue excessive data on subflows.net/mptcp/protocol.c+2 -20 replies
4/4mptcp: schedule work for better snd subflow selectionnet/mptcp/protocol.c+8 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [MPTCP] [PATCH v3 mptcp-next 0/4] mptcp: re-enable snd buf autotune

WRT to the previous iteration, this clean-up patch 2/4 dropping the left over 'use_backup' field, as suggested by Mat. No other change

Relevant bits from the previous cover letter:

There are still some sporadic self-test failures for assimetric links. Looks like they are caused by retransmissions/receiver dropping packets due to MPTCP level OoO check.

I'll try to address that asap, but I still consider this series for inclusion, so that it can stage a bit in the export branch.

Note: the last patch re-introduces the workqueue usage for the datapath (yes, it makes me feel sick, sad and tired :(. I was unable to avoid it.

Paolo Abeni (4):
mptcp: always graft subflow socket to parent.
mptcp: re-enable sndbuf autotune
mptcp: do not queue excessive data on subflows.
mptcp: schedule work for better snd subflow selection

 net/mptcp/protocol.c | 104 +++++++++++++++++--------------------------
 net/mptcp/protocol.h |  20 +++++++++
 net/mptcp/subflow.c  |  13 +++++-
 3 files changed, 73 insertions(+), 64 deletions(-)
Signature · 1 line
2.26.2