Skip to content

gpio: mvebu: pwm fixes and improvements

Baruch Siach linux-arm-kernel linux-gpio linux-pwm 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest4 patches 2 repliesIn review
  2. v45 patches 2 repliesApplied
  3. v35 patches 3 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v25 patches5 repliesSuperseded
v15 patches8 repliesSuperseded

Changes in v5 from the cover letter

* Drop a patch applied to the gpio tree

* Fix patch 4/4 description typo (Uwe)

* Reduce the number of multiplications (Uwe)

* Add spaces around '+' (Uwe)

* Use '1ULL' instead of explicit cast to reduce verbosity

* Add Linus' Reviewed-by tags to patches that are unchanged since v2

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4gpio: mvebu: improve pwm period calculation accuracydrivers/gpio/gpio-mvebu.c+2 -20 replies
2/4gpio: mvebu: make pwm .get_state closer to idempotentdrivers/gpio/gpio-mvebu.c+2 -20 replies
3/4gpio: mvebu: don't limit pwm period/duty_cycle to UINT_MAXdrivers/gpio/gpio-mvebu.c+2 -60 replies
4/4gpio: mvebu: improve handling of pwm zero on/off valuesdrivers/gpio/gpio-mvebu.c+23 -161 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchUwe Kleine-KönigLinus WalleijRussell King
1/4R-b R-b
2/4R-b R-b
3/4R-b R-b
4/4R-b Analyzed-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/4] gpio: mvebu: pwm fixes and improvements

This series adds a few related fixes to the pwm .apply and .get_state callbacks.

The first patch was originally part of the series adding Armada 8K/7K pwm support. I split it out to a separate series following review comments from Uwe Kleine-König who spotted a few more issues. There is no dependency between this and the Armada 8K/7K series.

v5:

* Drop a patch applied to the gpio tree

* Fix patch 4/4 description typo (Uwe)

* Reduce the number of multiplications (Uwe)

* Add spaces around '+' (Uwe)

* Use '1ULL' instead of explicit cast to reduce verbosity

* Add Linus' Reviewed-by tags to patches that are unchanged since v2

v4:

* Take advantage of zero value being treated as 2^32 by hardware. Rewrite

    patch 5/5 (Uwe).

v3:

* Improve patch 3/5 description (Uwe)

* Add more Reviewed-by tags from Uwe

v2:

Address Uwe Kleine-König comments.

* Improve patch 1/5 summary line

* Add more information to patch 1/5 description

* Add more information to patch 2/5 description

* Don't round period/duty_cycle up in .apply (patch 3/5)

* Expand the comment in path 5/5 based on RMK's analysis of hardware behaviour

* Add Uwe's Reviewed-by tags

Baruch Siach (4):
gpio: mvebu: improve pwm period calculation accuracy
gpio: mvebu: make pwm .get_state closer to idempotent
gpio: mvebu: don't limit pwm period/duty_cycle to UINT_MAX
gpio: mvebu: improve handling of pwm zero on/off values

 drivers/gpio/gpio-mvebu.c | 47 +++++++++++++++++++++------------------
 1 file changed, 25 insertions(+), 22 deletions(-)
Signature · 7 lines
2.29.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel