Skip to content

net/cxgbe: minor fixes for link related changes

Rahul Lakkireddy dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net/cxgbe: do not link down for every link config changedrivers/net/cxgbe/base/t4_hw.c+2 -40 replies
2/2net/cxgbe: avoid link FEC retraining during probedrivers/net/cxgbe/base/t4_hw.c drivers/net/cxgbe/cxgbe_ethdev.c+15 -170 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [dpdk-dev] [PATCH 0/2] net/cxgbe: minor fixes for link related changes

Patch 1 fixes issue with link status always getting set to down by driver for every link config change request. This is not required for some link config changes, like Tx/Rx pause on/off. Instead, driver should rely on actual link status returned by firmware in link config change reply.

Patch 2 fixes issue with link FEC retraining during probe. If firmware had already saved FEC before probe is completed, then use the saved FEC for further link configuration, instead of triggering link retraining. Also simplifies get fec ops.

Thanks,
Rahul

Rahul Lakkireddy (2):
net/cxgbe: do not link down for every link config change net/cxgbe: avoid link FEC retraining during probe

 drivers/net/cxgbe/base/t4_hw.c   | 17 ++++++++++++-----
 drivers/net/cxgbe/cxgbe_ethdev.c | 21 +++++----------------
 2 files changed, 17 insertions(+), 21 deletions(-)
Signature · 1 line
2.24.0