Skip to content

mptcp: re-enable sndbuf autotune

Paolo Abeni mptcp netdev 2 versions Applied

Status from this message: This series was applied to netdev/net-next.git (refs/heads/master):

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 6 repliesApplied 5/5
  2. v15 patches 1 replySuperseded

Changes in v2 from the cover letter

- fix a UaF in patch 5, see patch changelog for the details

Patches in v2 All 5 applied

#Subject and filesSizeRepliesApplied
1/5mptcp: always graft subflow socket to parentnet/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/subflow.c+14 -260 repliesApplied
2/5mptcp: re-enable sndbuf autotunenet/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/subflow.c+45 -330 repliesApplied
3/5mptcp: do not queue excessive data on subflowsnet/mptcp/protocol.c+2 -20 repliesApplied
4/5mptcp: schedule work for better snd subflow selectionnet/mptcp/protocol.c+8 -30 repliesApplied
5/5mptcp: implement delegated actionsnet/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/subflow.c+194 -45 repliesApplied

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchMat Martineau
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 net-next 0/5] mptcp: re-enable sndbuf autotune

The sendbuffer autotuning was unintentionally disabled as a side effect of the recent workqueue removal refactor. These patches re-enable id, with some extra care: with autotuning enable/large send buffer we need a more accurate packet scheduler to be able to use efficiently the available subflow bandwidth, especially when the subflows have different capacities.

The first patch cleans-up subflow socket handling, making the actual re-enable (patch 2) simpler.

Patches 3 and 4 improve the packet scheduler, to better cope with non trivial scenarios and large send buffer.

Finally patch 5 adds and uses some infrastructure to avoid the workqueue usage for the packet scheduler operations introduced by the previous patches.

v1 -> v2:
- fix a UaF in patch 5, see patch changelog for the details

Paolo Abeni (5):
mptcp: always graft subflow socket to parent
mptcp: re-enable sndbuf autotune
mptcp: do not queue excessive data on subflows
mptcp: schedule work for better snd subflow selection
mptcp: implement delegated actions

 net/mptcp/protocol.c | 179 ++++++++++++++++++++++++++++---------------
 net/mptcp/protocol.h |  87 +++++++++++++++++++++
 net/mptcp/subflow.c  |  55 ++++++++++++-
 3 files changed, 258 insertions(+), 63 deletions(-)
Signature · 1 line
2.26.2