Skip to content

dt: build overlays

Viresh Kumar linux-devicetree linux-kbuild lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest6 patches 23 repliesIn review
  2. v66 patches 14 repliesSuperseded
  3. v55 patches 32 repliesSuperseded

Changes in v7 from the cover letter

- Add a comment in scripts/dtc/Makefile
- Add Ack from Masahiro for patch 4/6.
- Drop word "merge" from commit log of 2/6.
- Split apply_static_overlay, static_test.dtb, and static_base.dts into two parts to handle overlay_base.dts and testcases.dts separately.

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6scripts: dtc: Fetch fdtoverlay.c from external DTC projectscripts/dtc/update-dtc-source.sh+2 -10 replies
2/6scripts: dtc: Build fdtoverlay toolscripts/dtc/Makefile+7 -10 replies
3/6scripts: dtc: Remove the unused fdtdump.c filescripts/dtc/fdtdump.c+0 -1630 replies
4/6kbuild: Add support to build overlays (%.dtbo).gitignore Makefile scripts/Makefile.dtbinst +1 more+13 -112 replies
5/6of: unittest: Create overlay_common.dtsi and testcases_common.dtsidrivers/of/unittest-data/overlay_base.dts drivers/of/unittest-data/overlay_common.dtsi drivers/of/unittest-data/testcases.dts +2 more+118 -1073 replies
6/6of: unittest: Statically apply overlays using fdtoverlaydrivers/of/unittest-data/Makefile drivers/of/unittest-data/static_base_1.dts drivers/of/unittest-data/static_base_2.dts+64 -07 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchMasahiro YamadaGeert Uytterhoeven
1/6
2/6
3/6
4/6A-b R-b T-b
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH V7 0/6] dt: build overlays

Hi,

This patchset makes necessary changes to the kernel to add support for building overlays (%.dtbo) and the required fdtoverlay tool. This also builds static_test.dtb using most of the existing overlay tests present in drivers/of/unittest-data/ for better test coverage.

Note that in order for anyone to test this stuff, you need to manually run the ./update-dtc-source.sh script once to fetch the necessary changes from the external DTC project (i.e. fdtoverlay.c and this[1] patch).

I have tested this patchset for static and runtime testing (on Hikey board) and no issues were reported.

V7:
- Add a comment in scripts/dtc/Makefile
- Add Ack from Masahiro for patch 4/6.
- Drop word "merge" from commit log of 2/6.
- Split apply_static_overlay, static_test.dtb, and static_base.dts into two parts to handle overlay_base.dts and testcases.dts separately.

V6:
- Create separate rules for dtbo-s and separate entries in .gitignore in 4/6 (Masahiro).
- A new file layout for handling all overlays for existing and new tests 5/6 (Frank).
- Include overlay.dts as well now in 6/6 (Frank).

V5:

- Don't reuse DTC_SOURCE for fdtoverlay.c in patch 1/5 (Frank).

- Update .gitignore and scripts/Makefile.dtbinst, drop dtbo-y syntax and DTC_FLAGS += -@ in patch 4/5 (Masahiro).

- Remove the intermediate dtb, rename output to static_test.dtb, don't use overlay.dtb and overlay_base.dtb for static builds, improved layout/comments in Makefile for patch 5/5 (Frank).

--
Viresh

[1] https://github.com/dgibson/dtc/commit/163f0469bf2ed8b2fe5aa15bc796b93c70243ddc
[2] https://lore.kernel.org/lkml/[email protected]/

Viresh Kumar (6):
scripts: dtc: Fetch fdtoverlay.c from external DTC project
scripts: dtc: Build fdtoverlay tool
scripts: dtc: Remove the unused fdtdump.c file
kbuild: Add support to build overlays (%.dtbo)
of: unittest: Create overlay_common.dtsi and testcases_common.dtsi
of: unittest: Statically apply overlays using fdtoverlay

 .gitignore                                    |   1 +
 Makefile                                      |   5 +-
 drivers/of/unittest-data/Makefile             |  56 ++++++
 drivers/of/unittest-data/overlay_base.dts     |  90 +---------
 drivers/of/unittest-data/overlay_common.dtsi  |  91 ++++++++++
 drivers/of/unittest-data/static_base_1.dts    |   4 +
 drivers/of/unittest-data/static_base_2.dts    |   4 +
 drivers/of/unittest-data/testcases.dts        |  18 +-
 .../of/unittest-data/testcases_common.dtsi    |  19 ++
 .../of/unittest-data/tests-interrupts.dtsi    |   7 -
 scripts/Makefile.dtbinst                      |   3 +
 scripts/Makefile.lib                          |   5 +
 scripts/dtc/Makefile                          |   8 +-
 scripts/dtc/fdtdump.c                         | 163 ------------------
 scripts/dtc/update-dtc-source.sh              |   3 +-
 15 files changed, 204 insertions(+), 273 deletions(-)
 create mode 100644 drivers/of/unittest-data/overlay_common.dtsi
 create mode 100644 drivers/of/unittest-data/static_base_1.dts
 create mode 100644 drivers/of/unittest-data/static_base_2.dts
 create mode 100644 drivers/of/unittest-data/testcases_common.dtsi
 delete mode 100644 scripts/dtc/fdtdump.c

base-commit: 6ee1d745b7c9fd573fba142a2efdad76a9f1cb04

Signature · 1 line
2.25.0.rc1.19.g042ed3e048af