Skip to content

submission path cleanups and optimisation

Pavel Begunkov io-uring 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11io_uring: kill fictitious submit iteration indexfs/io_uring.c+2 -20 replies
2/11io_uring: keep io_*_prep() naming consistentfs/io_uring.c+4 -40 replies
3/11io_uring: don't duplicate ->file check in sfrfs/io_uring.c+0 -30 replies
4/11io_uring: move io_init_req()'s definitionfs/io_uring.c+107 -1070 replies
5/11io_uring: move io_init_req() into io_submit_sqe()fs/io_uring.c+15 -170 replies
6/11io_uring: move req link into submit_statefs/io_uring.c+14 -140 replies
7/11io_uring: don't submit link on errorfs/io_uring.c+4 -40 replies
8/11io_uring: split sqe-prep and async setupfs/io_uring.c+70 -500 replies
9/11io_uring: do io_*_prep() early in io_submit_sqe()fs/io_uring.c+24 -350 replies
10/11io_uring: don't do async setup for links' headsfs/io_uring.c+0 -30 replies
11/11io_uring: fail links more in io_submit_sqe()fs/io_uring.c+8 -130 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/11] submission path cleanups and optimisation

Refactor how we do io_req_prep(), which is currently spilled across multiple ifs and functions, that's a mess which is hard to validate. It also cuts down amount of work we're doing during submission, where nops(batch=32) test shows 15217 vs 16830 KIOPS, before and after respectively.

1-6 are easy and should change nothing functionally.

7/11 cancels all the link, where currently it can be partially executed. That happens only in some cases, and currently is not consistent. That change alters the user visible behaviour and breaks one liburing test, but looks like the right thing to do. (IMHO, the test is buggy in that regard).

8/11 makes us to do one more opcode switch for where we previously were doing io_req_defer_prep(). That includes all links, but the total performance win, removing an extra async setup in 10/11, and just making all the thing cleaner justifies it well enough.

Pavel Begunkov (11):
io_uring: kill fictitious submit iteration index
io_uring: keep io_*_prep() naming consistent
io_uring: don't duplicate ->file check in sfr
io_uring: move io_init_req()'s definition
io_uring: move io_init_req() into io_submit_sqe()
io_uring: move req link into submit_state
io_uring: don't submit link on error
io_uring: split sqe-prep and async setup
io_uring: do io_*_prep() early in io_submit_sqe()
io_uring: don't do async setup for links' heads
io_uring: fail links more in io_submit_sqe()

 fs/io_uring.c | 460 +++++++++++++++++++++++++-------------------------
 1 file changed, 228 insertions(+), 232 deletions(-)
Signature · 1 line
2.24.0