Skip to content

remove task file notes

Pavel Begunkov io-uring 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest8 patches 1 replyIn review
  2. v36 patches 0 repliesSuperseded
  3. v26 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v18 patches2 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8io_uring: make del_task_file more forgivingfs/io_uring.c+8 -50 replies
2/8io_uring: introduce ctx to tctx back mapfs/io_uring.c+44 -140 replies
3/8io_uring: do ctx initiated file note removalfs/io_uring.c+46 -20 replies
4/8io_uring: don't take task ring-file notesfs/io_uring.c+2 -30 replies
5/8io_uring: index io_uring->xa by ctx not filefs/io_uring.c include/linux/io_uring.h+12 -140 replies
6/8io_uring: warn when ring exit takes too longfs/io_uring.c+5 -00 replies
7/8io_uring: cancel reqs of all iowq's on ring exitfs/io_uring.c+39 -30 replies
8/8io-wq: warn on creating manager awhile exitingfs/io-wq.c+2 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 5.12 0/8] remove task file notes

Introduce a mapping from ctx to all tctx, and using that removes file notes, i.e. taking a io_uring file note previously stored in task->io_uring->xa. It's needed because we don't free io_uring ctx until all submitters die/exec, and it became worse after killing
->flush(). There are rough corner in a form of not behaving nicely,
I'll address in follow-up patches. Also use it to do cancellations right.

The torture is as simple as below. It will get OOM in no time. Also, I plan to use it to fix recently broken cancellations.

while (1) {
	assert(!io_uring_queue_init(8, &ring, 0));
	io_uring_queue_exit(&ring);
}

WARNING: hangs without reverting sq park refactoring

v2: rebase (resolve conflicts)
drop taken 2 patches
v3: use jiffies in 6/6 (Jens)
v4: 2 patches, 7/8 fix cancellation regressions

Pavel Begunkov (8):
io_uring: make del_task_file more forgiving
io_uring: introduce ctx to tctx back map
io_uring: do ctx initiated file note removal
io_uring: don't take task ring-file notes
io_uring: index io_uring->xa by ctx not file
io_uring: warn when ring exit takes too long
io_uring: cancel reqs of all iowq's on ring exit
io-wq: warn on creating manager awhile exiting

 fs/io-wq.c               |   2 +
 fs/io_uring.c            | 173 ++++++++++++++++++++++++++++++++-------
 include/linux/io_uring.h |   2 +-
 3 files changed, 147 insertions(+), 30 deletions(-)
Signature · 1 line
2.24.0